Skip to content

feat: Add SessionPlayer as default tab in browser test editor #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
allansson wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −19
Draft

feat: Add SessionPlayer as default tab in browser test editor #1162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 17 additions & 18 deletions src/views/BrowserTestEditor/BrowserTestEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { Group, Panel, Separator } from '@/components/primitives/ResizablePanel'
import { routeMap } from '@/routeMap'
import { BrowserTestFile } from '@/schemas/browserTest/v1'
import { StudioFile } from '@/types'
import { SessionPlayer } from '@src/views/Validator/Browser/SessionPlayer/SessionPlayer'

import { NetworkInspector } from '../Validator/Browser/NetworkInspector'
import { useDebugSession } from '../Validator/Validator.hooks'
Expand Down Expand Up @@ -95,27 +96,25 @@ function BrowserTestEditorView({ file, data }: BrowserTestEditorViewProps) {
`}
>
<Panel id="main" minSize={200}>
<Tabs.Root asChild defaultValue="script">
<Tabs.Root asChild defaultValue="replay">
<Flex direction="column" height="100%" width="100%">
<Tabs.List>
<Tabs.Trigger
disabled
css={css`
/*
* Since we currently only have a single tab, we disable the
* hover styling. This should be removed once we have more tabs.
*/
cursor: default;

&:hover .rt-TabsTriggerInner {
background-color: transparent;
}
`}
value="script"
>
Script
</Tabs.Trigger>
<Tabs.Trigger value="replay">Replay</Tabs.Trigger>
<Tabs.Trigger value="script">Script</Tabs.Trigger>
</Tabs.List>
<Tabs.Content
css={css`
flex: 1 1 0;
overflow: hidden;
`}
value="replay"
>
<SessionPlayer
key={session.id}
session={session}
highlightedSelector={null}
/>
</Tabs.Content>
<Tabs.Content
css={css`
flex: 1 1 0;
Expand Down
3 changes: 2 additions & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
"jsx": "react-jsx",
"jsxImportSource": "@emotion/react",
"paths": {
"@/*": ["src/*"]
"@/*": ["src/*"],
"@src/*": ["src/*"]
},
"types": [
"vite/client",
Expand Down
Loading