browser: avoid test browser panic on missing browser#5685
Draft
inancgumus wants to merge 1 commit intoadd/testbrowser-sample-drain-optfrom
Draft
browser: avoid test browser panic on missing browser#5685inancgumus wants to merge 1 commit intoadd/testbrowser-sample-drain-optfrom
inancgumus wants to merge 1 commit intoadd/testbrowser-sample-drain-optfrom
Conversation
Replace Fatalf with Errorf + early return so newTestBrowser always returns a non-nil *testBrowser. Fatalf calls runtime.Goexit which terminates the goroutine without returning, leaving callers in parent scopes with a nil pointer that panics on field access.
inancgumus
force-pushed
the
fix/test-browser-panic-on-nil-browser
branch
from
ed90eaa to
3b2ed1a
Compare
inancgumus
changed the base branch from
master
to
add/testbrowser-sample-drain-opt
inancgumus
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
inancgumus
force-pushed
the
add/testbrowser-sample-drain-opt
branch
from
b37c358 to
4e0eb2e
Compare
inancgumus
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
inancgumus
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
inancgumus
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
newTestBrowserno longer panics when the browser executable isn't available.Why?
Browser tests panic on ARM CI runners (and any environment without Chromium installed) instead of failing cleanly. This makes CI output harder to read and masks the actual problem behind a huge stack trace.