feat: unmarshal grpc-status-details-bin trailer into error details#5711
Open
yordis wants to merge 1 commit intografana:masterfrom
Open
feat: unmarshal grpc-status-details-bin trailer into error details#5711yordis wants to merge 1 commit intografana:masterfrom
yordis wants to merge 1 commit intografana:masterfrom
Conversation
|
|
2013833 to
7d7423e
Compare
Mark google.golang.org/genproto/googleapis/rpc as a direct dependency since grpcext/conn.go directly imports the rpc/status package.
52ea233 to
00021c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Read the
grpc-status-details-bintrailer from gRPC error responses and expose its structured details inresponse.error.detailsin k6 test scripts.Also fixes marshaling of standard Google protobuf types in error responses by using
Resolver: nilinstead of the per-connection user-defined type registry.Why?
gRPC servers use the
grpc-status-details-bintrailer as the standard mechanism to attach rich structured error information — things likeErrorInfo(reason, domain, metadata),BadRequestfield violations,RetryInfo, etc. Previously k6 ignored this trailer entirely, always returning an emptydetailsarray even when the server sent structured errors.Two issues were preventing this from working:
response.error.detailswas always empty regardless of what the server sent.Resolver: c.types, which only knows about user-defined protobuf types loaded viaclient.load(). Standard Google types likegoogle.rpc.ErrorInfoare not in that registry, so they would marshal to empty objects. UsingResolver: nilfalls back to the global protobuf registry which resolves them correctly.Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)