websockets: buffered amount not tracked in ArrayBuffer for typed arrays or DataView - fixes #5715#5716
Open
prakharbirla-ng wants to merge 1 commit intografana:masterfrom
Open
websockets: buffered amount not tracked in ArrayBuffer for typed arrays or DataView - fixes #5715#5716prakharbirla-ng wants to merge 1 commit intografana:masterfrom
prakharbirla-ng wants to merge 1 commit intografana:masterfrom
Conversation
…ys or DataView fixes grafana#5715
prakharbirla-ng
requested review from
ankur22 and
szkiba
and removed request for
a team
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
When sending TypedArrays, bufferedAmount was not incremented.
Fixes the bug introduced in #5358
Why?
Buffered amount should be tracked when data is added to the queue so that it does not become negative.
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)
Closes #5715