feat(k6/browser): support or() locator#5723
Open
amontfaucon wants to merge 1 commit intografana:masterfrom
Open
feat(k6/browser): support or() locator#5723amontfaucon wants to merge 1 commit intografana:masterfrom
amontfaucon wants to merge 1 commit intografana:masterfrom
Conversation
|
|
2f837fc to
cd9e30d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add support for or() in locators.
Why?
This is a feature supported in playwright and hinders reusability of scripts with k6. It is very useful in improving test stability (e.g. handle login screens, MFA prompt, cookie consent that may not trigger systematically).
Implementation is inspired from the one of playwright. Only
or()was added for now to keep it simple sinceand()is easier to achieve through other means.For example, with this PR one can do the following:
Note: this will require a change in the TS types definitions.
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)