Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix label of prometheus.operator.probes component #1368

Merged
merged 1 commit into from
Mar 29, 2025
Merged

Fix label of prometheus.operator.probes component #1368

merged 1 commit into from
Mar 29, 2025

Conversation

ndrpnt
Copy link
Contributor

@ndrpnt ndrpnt commented Mar 25, 2025

Small typo fix. Should I update the corresponding test snapshots ?

@ndrpnt ndrpnt requested review from a team, petewall and rlankfo as code owners March 25, 2025 21:52
@petewall
Copy link
Collaborator

Thank you!
The GH Action tests will tell us if we need to update the unit tests.

@petewall
Copy link
Collaborator

Yeah, please update the test snapshots.

@ndrpnt
Copy link
Contributor Author

ndrpnt commented Mar 27, 2025

Done

@petewall petewall merged commit f360f34 into grafana:main Mar 29, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petewall petewall petewall approved these changes

@rlankfo rlankfo Awaiting requested review from rlankfo rlankfo is a code owner

@skl skl Awaiting requested review from skl skl is a code owner automatically assigned from grafana/k8s-monitoring-dev

@nevermind89x nevermind89x Awaiting requested review from nevermind89x nevermind89x is a code owner automatically assigned from grafana/k8s-monitoring-dev

@sleepyfoodie sleepyfoodie Awaiting requested review from sleepyfoodie sleepyfoodie is a code owner automatically assigned from grafana/k8s-monitoring-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndrpnt @petewall