fix: use glob syntax instead of regex in Beyla discovery config#2485
Merged
fix: use glob syntax instead of regex in Beyla discovery config#2485
Conversation
Beyla interprets discovery fields as glob patterns, not regex. The default config used "." (regex any-char) instead of "*" (glob wildcard) for k8s_namespace, and regex alternation "|" instead of glob brace alternation for exe_path exclusions. This caused Beyla to discover zero services and silently skip exclusions. Fixes #2484 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
TruffleHog Scan Results Summary: Found 7 potential secrets (0 verified, 7 unverified)
Review: Check if unverified secrets are false positives. Ignoring False Positives: This works for files that support line numbers (most source files). After adding the comment, push your changes and the scan will re-run. |
Signed-off-by: Pete Wall <pete.wall@grafana.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Beyla discovery defaults in the Helm chart by using glob syntax (as Beyla expects) instead of regex syntax, restoring service discovery and exclusion behavior.
Changes:
- Update default
k8s_namespacematch-all from.(regex) to*(glob) in generated Beyla config. - Update default
exe_pathexclusion from regex alternation to glob brace alternation. - Regenerate affected rendered outputs / snapshots and update the exclude-by-namespace example to use the corrected glob.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/k8s-monitoring/charts/feature-auto-instrumentation/templates/_beyla-config.tpl | Fixes the default Beyla discovery config to use glob patterns (*, {...}) instead of regex syntax. |
| charts/k8s-monitoring/tests/feature_beyla_config_test.yaml | Updates test expectations to match corrected rendered discovery defaults. |
| charts/k8s-monitoring/tests/platform/openshift/.rendered/output.yaml | Updates rendered snapshot with corrected glob patterns and checksum. |
| charts/k8s-monitoring/tests/platform/grafana-cloud/k8s-monitoring/.rendered/output.yaml | Updates rendered snapshot with corrected glob patterns and checksum. |
| charts/k8s-monitoring/docs/examples/tolerations/output.yaml | Updates example rendered output to reflect corrected discovery defaults. |
| charts/k8s-monitoring/docs/examples/resource-requests-and-limits/output.yaml | Updates example rendered output to reflect corrected discovery defaults. |
| charts/k8s-monitoring/docs/examples/private-image-registries/individual/output.yaml | Updates example rendered output to reflect corrected discovery defaults. |
| charts/k8s-monitoring/docs/examples/images/images-by-digest/output.yaml | Updates example rendered output to reflect corrected discovery defaults. |
| charts/k8s-monitoring/docs/examples/features/auto-instrumentation/span-metrics-only/output.yaml | Updates example rendered output to reflect corrected discovery defaults. |
| charts/k8s-monitoring/docs/examples/features/auto-instrumentation/beyla-metrics/output.yaml | Updates example rendered output to reflect corrected discovery defaults. |
| charts/k8s-monitoring/docs/examples/exclude-by-namespace/values.yaml | Fixes the example values to use k8s_namespace: "*" (glob match-all). |
| charts/k8s-monitoring/docs/examples/exclude-by-namespace/README.md | Fixes the example documentation to use k8s_namespace: "*" (glob match-all). |
| charts/k8s-monitoring/docs/examples/exclude-by-namespace/output.yaml | Updates example rendered output to reflect the corrected glob pattern and checksum. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mariomac
approved these changes
Apr 14, 2026
Contributor
mariomac
left a comment
mariomac
left a comment
There was a problem hiding this comment.
Correct to me! just a couple of corrections in docs/examples/exclude-by-namespace
Signed-off-by: Pete Wall <pete.wall@grafana.com>
Collaborator
Author
|
@mariomac , updated |
petewall
added a commit
that referenced
this pull request
Apr 14, 2026
* fix: use glob syntax instead of regex in Beyla discovery config Beyla interprets discovery fields as glob patterns, not regex. The default config used "." (regex any-char) instead of "*" (glob wildcard) for k8s_namespace, and regex alternation "|" instead of glob brace alternation for exe_path exclusions. This caused Beyla to discover zero services and silently skip exclusions. Fixes #2484 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: regenerate all rendered outputs with corrected Beyla glob patterns Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix unit test snapshot Signed-off-by: Pete Wall <pete.wall@grafana.com> * change services to instrument Signed-off-by: Pete Wall <pete.wall@grafana.com> --------- Signed-off-by: Pete Wall <pete.wall@grafana.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beyla interprets discovery fields as glob patterns, not regex. The default
config used "." (regex any-char) instead of "*" (glob wildcard) for
k8s_namespace, and regex alternation "|" instead of glob brace alternation
for exe_path exclusions. This caused Beyla to discover zero services and
silently skip exclusions.
Fixes #2484