chore(linting): combobox, silence warnings#1845
Draft
L2D2Grafana wants to merge 2 commits intomainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary 📝
Selectusages to@grafana/uiCombobox, tightens types and test typings, and applies small fixes inMousetrap,KeybindingSet,combineResponses,shardQuerySplitting, andtext.ts(including replacing an invaliddeprecationdisable with@typescript-eslint/no-deprecatedfor theexecCommandfallback).Input+ scrollablerole="listbox"list so saved/default labels can show a Grafanasaveicon beside the name; placeholder and tooltip behavior stay aligned with existing copy (“Search labels”).eslint.config.mjs,jest-setup.js) and a locale string touch-up where needed.Test 🧪
yarn typecheckyarn lint