Skip to content

chore(linting): combobox, silence warnings#1845

Draft
L2D2Grafana wants to merge 2 commits intomainfrom
l2d2/chore-linting
Draft

chore(linting): combobox, silence warnings#1845
L2D2Grafana wants to merge 2 commits intomainfrom
l2d2/chore-linting

Conversation

@L2D2Grafana
Copy link
Copy Markdown
Collaborator

Summary 📝

  • Resolves ESLint / TypeScript noise across the app: migrates several Select usages to @grafana/ui Combobox, tightens types and test typings, and applies small fixes in Mousetrap, KeybindingSet, combineResponses, shardQuerySplitting, and text.ts (including replacing an invalid deprecation disable with @typescript-eslint/no-deprecated for the execCommand fallback).
  • Replaces the “Add label” popover implementation with a searchable Input + scrollable role="listbox" list so saved/default labels can show a Grafana save icon beside the name; placeholder and tooltip behavior stay aligned with existing copy (“Search labels”).
  • Minor config/test harness updates (eslint.config.mjs, jest-setup.js) and a locale string touch-up where needed.

Test 🧪

  • yarn typecheck
  • yarn lint
  • Check select udpate to combobox manually
Screenshot 2026-04-09 at 1 12 49 PM Screenshot 2026-04-09 at 1 12 38 PM Screenshot 2026-04-09 at 1 12 17 PM Screenshot 2026-04-09 at 1 12 10 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant