feat: Add PartitionManager and move this out of ingest_limits.go #16602
+2,049
−228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobinson-grafana
force-pushed
the
grobinson/create-partition-manager
branch
from
f16dfeb to
27d7317
Compare
| }) | ||
| } | ||
| } | ||
|
|
||
| func TestNewIngestLimits(t *testing.T) { |
There was a problem hiding this comment.
I think we should delete this test, it doesn't test anything meaningful IMO.
grobinson-grafana
force-pushed
the
grobinson/create-partition-manager
branch
2 times, most recently
from
357f1df to
644e82a
Compare
This commit adds a PartitionManager that is responsible for tracking owned partitions. It moves this logic out of ingest_limits.go. In a follow up PR, I will also move kgo.onPartitionsAssigned, kgo.onPartitionsRevoked and kgo.onPartitionsLost to the PartitionManager.
grobinson-grafana
force-pushed
the
grobinson/create-partition-manager
branch
from
644e82a to
5249250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This commit adds a
PartitionManagerthat is responsible for tracking owned partitions. It moves this logic out ofingest_limits.go. The motivation here is to reduce amount of "logic" that is happening inIngestLimitsand modularize it's responsibilities a bit better.In a follow up PR, I will also move
kgo.onPartitionsAssigned,kgo.onPartitionsRevokedandkgo.onPartitionsLostto thePartitionManager.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR