refactor: extractors can return multiple samples #17064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorwhitney
changed the title
trevorwhitney
force-pushed
the
refactor-extractors-multiple-samples
branch
from
7e9be11 to
eb615eb
Compare
6 tasks
chaudum
reviewed
Apr 23, 2025
pkg/chunkenc/memchunk.go
Outdated
Comment on lines
1734
to
1735
| cur: []logproto.Sample{}, | ||
| currLabels: []log.LabelsResult{}, |
There was a problem hiding this comment.
nit: for the sake of consistency I would name them curr and currLabels
pkg/chunkenc/memchunk.go
Outdated
Comment on lines
1757
to
1760
| if len(e.cur) == 1 { | ||
| e.cur = e.cur[:0] | ||
| e.currLabels = e.currLabels[:0] | ||
| } |
There was a problem hiding this comment.
This was very confusing for me. Could you add a comment what's happening here: element at index 0 is the current one and there are no more next elements, meaning that in order to load next batch, we need to clear the current slice curr
trevorwhitney
requested review from
periklis,
xperimental and
JoaoBraveCoding
as code owners
trevorwhitney
force-pushed
the
refactor-extractors-multiple-samples
branch
from
5fef96f to
6b61619
Compare
chaudum
approved these changes
May 8, 2025
Signed-off-by: Trevor Whitney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR refactors the
SampleExtractorinterface to allowProcessto return multiple samples for a specific line. This refactor is a prerequisite for #17149, which allows extractors in a Multi-Variant query to pre-process common stages in an extraction pipeline (such as line/label filters, logfmt, etc) and then run only the extraction specific stage over the pre-process log line, which should significantly reduce the amount of work done when process a multi-variant query.Originally, the multi-variant query work refactored sample evaluation to be able to accept multiple extractors. this was the wrong approach as it limits our ability to pre-process a log line. The extractors do not expose much about their internal pipeline, so it would be difficult to find common stages. Furthermore, the extractor does not know the context of the line being processed until the call to
.Process(), making it hard for the extractors to share state per log line between them.Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR