Skip to content

fix: ConfigMap "grafana-dashboard-loki_thanos_object_storage" is invalid #17090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fitz123
Copy link

@fitz123 fitz123 commented Apr 9, 2025

What this PR does / why we need it:
Fixes an invalid ConfigMap name by replacing underscores with hyphens in the dashboard filename. The current name loki_thanos_object_storage.json results in a ConfigMap with name grafana-dashboard-loki_thanos_object_storage, which fails Kubernetes validation as it contains underscores. The PR changes the filename to loki-thanos-object-storage.json to ensure the resulting ConfigMap name complies with Kubernetes naming requirements.

Which issue(s) this PR fixes:
NA

Special notes for your reviewer:
The error occurs because Kubernetes ConfigMap names must follow the RFC 1123 subdomain naming convention, which doesn't allow underscores. This is a simple fix to ensure dashboard deployments succeed.

@fitz123 fitz123 requested a review from a team as a code owner April 9, 2025 16:48
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants