fix: ConfigMap "grafana-dashboard-loki_thanos_object_storage" is invalid #17090
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes an invalid ConfigMap name by replacing underscores with hyphens in the dashboard filename. The current name loki_thanos_object_storage.json results in a ConfigMap with name grafana-dashboard-loki_thanos_object_storage, which fails Kubernetes validation as it contains underscores. The PR changes the filename to loki-thanos-object-storage.json to ensure the resulting ConfigMap name complies with Kubernetes naming requirements.
Which issue(s) this PR fixes:
NA
Special notes for your reviewer:
The error occurs because Kubernetes ConfigMap names must follow the RFC 1123 subdomain naming convention, which doesn't allow underscores. This is a simple fix to ensure dashboard deployments succeed.