Skip to content

chore(ingest-limits): Remove sticky-balancer #17103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

chore(ingest-limits): Remove sticky-balancer #17103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions pkg/limits/ingest_limits.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,15 +173,7 @@ func NewIngestLimits(cfg Config, logger log.Logger, reg prometheus.Registerer) (
s.client, err = client.NewReaderClient(kCfg, metrics, logger,
kgo.ConsumerGroup(consumerGroup),
kgo.ConsumeTopics(kCfg.Topic),
// TODO(periklis): Remove the sticky balancer once we rolled out
// the cooperative sticky balancer. According to KIP-429, once a
// group is using cooperative sticky balancing, it is unsafe to have
// a member join the group that does not support cooperative balancing.
// See group_balancer.go:CooperativeStickyBalancer() for more details.
kgo.Balancers(
kgo.StickyBalancer(),
kgo.CooperativeStickyBalancer(),
),
kgo.Balancers(kgo.CooperativeStickyBalancer()),
kgo.ConsumeResetOffset(kgo.NewOffset().AfterMilli(time.Now().Add(-s.cfg.WindowSize).UnixMilli())),
kgo.OnPartitionsAssigned(s.onPartitionsAssigned),
kgo.OnPartitionsRevoked(s.onPartitionsRevoked),
Expand Down