Skip to content

fix: fix timeout and series progress marker for same requests with different shards #17125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

fix: fix timeout and series progress marker for same requests with different shards #17125

merged 1 commit into from
Apr 14, 2025

Conversation

sandeepsukhani
Copy link
Contributor

What this PR does / why we need it:
It includes two fixes in tracking stream progress for deletion:

  1. Do not clear stream progress when we hit a timeout so that we skip the already processed streams in the next attempt.
  2. Store start/end time of the requests in the progress tracker since shared requests have same request ID.

Checklist

  • Tests updated

@sandeepsukhani sandeepsukhani requested a review from a team as a code owner April 11, 2025 10:40
@sandeepsukhani sandeepsukhani force-pushed the deletion-stream-progress-tracking-fixes branch from 6a17ae5 to bbb134e Compare April 11, 2025 10:50
@sandeepsukhani sandeepsukhani merged commit 288ec8c into main Apr 14, 2025
61 checks passed
@sandeepsukhani sandeepsukhani deleted the deletion-stream-progress-tracking-fixes branch April 14, 2025 04:14
@sandeepsukhani sandeepsukhani added type/bug Somehing is not working as expected backport k250 labels Apr 14, 2025
loki-gh-app bot pushed a commit that referenced this pull request Apr 14, 2025
@sandeepsukhani @grafana-delivery-bot
fix: fix timeout and series progress marker for same requests with di…
a68cd30 
…fferent shards (#17125)

(cherry picked from commit 288ec8c)
@loki-gh-app loki-gh-app bot mentioned this pull request Apr 14, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul1r paul1r paul1r approved these changes

Assignees
No one assigned
Labels
backport k250 size/M type/bug Somehing is not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandeepsukhani @paul1r