Skip to content

build: add GO_VERSION to workflows and update build image Dockerfile #20114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kim-Yukyung wants to merge 3 commits into
base: main
Choose a base branch
from
Open

build: add GO_VERSION to workflows and update build image Dockerfile #20114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f199ca
feat(build): add GO_VERSION to workflows and update build image Docke…
Kim-Yukyung Dec 4, 2025
9048985
feat(build): add GO_VERSION to workflows
Kim-Yukyung Dec 4, 2025
8a6499b
Merge branch 'main' into fix/19818
Kim-Yukyung Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/release-workflows.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ local weeklyImageJobs = {
versioningStrategy='always-bump-patch',
) + {
name: 'Prepare Patch Release PR',
env+: {
GO_VERSION: goVersion,
},
}, false, false
),
'minor-release-pr.yml': std.manifestYamlDoc(
Expand All @@ -79,6 +82,9 @@ local weeklyImageJobs = {
versioningStrategy='always-bump-minor',
) + {
name: 'Prepare Minor Release PR from Weekly',
env+: {
GO_VERSION: goVersion,
},
}, false, false
),
'release.yml': std.manifestYamlDoc(
Expand All @@ -91,7 +97,11 @@ local weeklyImageJobs = {
releaseBranchTemplate='release-\\${major}.\\${minor}.x',
releaseRepo='grafana/loki',
useGitHubAppToken=true,
), false, false
) + {
env+: {
GO_VERSION: goVersion,
},
}, false, false
),
'check.yml': std.manifestYamlDoc({
name: 'check',
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/minor-release-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ env:
DOCKER_USERNAME: "grafana"
DRY_RUN: false
GITHUB_APP: "loki-gh-app"
GO_VERSION: "1.25.4"
IMAGE_PREFIX: "grafana"
RELEASE_LIB_REF: "dfe753760ce6ec2f4549fc11d2df24a2aa584e3f"
RELEASE_REPO: "grafana/loki"
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/patch-release-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ env:
DOCKER_USERNAME: "grafana"
DRY_RUN: false
GITHUB_APP: "loki-gh-app"
GO_VERSION: "1.25.4"
IMAGE_PREFIX: "grafana"
RELEASE_LIB_REF: "dfe753760ce6ec2f4549fc11d2df24a2aa584e3f"
RELEASE_REPO: "grafana/loki"
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ concurrency:
env:
BUILD_ARTIFACTS_BUCKET: "loki-build-artifacts"
GITHUB_APP: "loki-gh-app"
GO_VERSION: "1.25.4"
IMAGE_PREFIX: "grafana"
PUBLISH_TO_GCS: false
RELEASE_LIB_REF: "dfe753760ce6ec2f4549fc11d2df24a2aa584e3f"
Expand Down
2 changes: 1 addition & 1 deletion loki-build-image/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# tag of the Docker image in `../.drone/drone.jsonnet` and run `make drone`.
# See ../docs/sources/community/maintaining/release-loki-build-image.md for instructions
# on how to publish a new build image.
ARG GO_VERSION=1.25
ARG GO_VERSION=1.25.4
ARG GOLANG_BASE_IMAGE=golang:${GO_VERSION}-trixie

# Install helm (https://helm.sh/) and helm-docs (https://github.com/norwoodj/helm-docs) for generating Helm Chart reference.
Expand Down