-
Notifications
You must be signed in to change notification settings - Fork 3.9k
feat: Handle state change lock in prepare downscale #20141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Segflow
wants to merge
10
commits into
main
Choose a base branch
from
meher/add-state-change-locked
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+21,205
−14,241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
794c9cf to
452b9fd
Compare
Contributor
|
💻 Deploy preview available (feat: Handle state change lock in prepare downscale ): |
dfb82b2 to
42464d2
Compare
Segflow
commented
Dec 10, 2025
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is generated using make doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is part of proposal 4 described in this design document.
PR grafana/dskit#799 adds the ability to lock state change, this PR updates the prepare downscale handler to return 409 if the state change is locked.
We also have a PR in rollout-operator that properly handles this status code: grafana/rollout-operator#343
Notes to reviewer:
dskit #759 made it not possible to use a zero heartbeat-period or zero heartbeat-timeout in the ring configuration.
I had to update some
pkg/rulerandpkg/limitstests to ensure both these fields are set otherwise the test fails.We also removed
0 = disabledfrom our configuration documents. We do not use it and we believe that should be an incorrect configuration.Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR