Skip to content

chore: add stream count to metrics.go for queriers #20215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slim-bean wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: add stream count to metrics.go for queriers #20215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7e8c58
calculate unique streams when calling GetChunkRef and update stats
slim-bean Dec 10, 2025
9ccc166
update name
slim-bean Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pkg/indexgateway/gateway.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,16 @@ func (g *Gateway) GetChunkRef(ctx context.Context, req *logproto.GetChunkRefRequ
result.Stats.PostFilterChunks = int64(initialChunkCount) // populate early for error reponses
result.Stats.ChunkRefsLookupTime = chunkRefsLookupDuration.Seconds()

// Compute unique streams matched from chunk refs
// Allocate map size based on chunk count since unique streams <= number of chunks
{
seen := make(map[uint64]struct{}, initialChunkCount)
for _, ref := range result.Refs {
seen[ref.Fingerprint] = struct{}{}
}
result.Stats.TotalStreams = int64(len(seen))
}

defer func() {
if err == nil {
g.metrics.preFilterChunks.WithLabelValues(routeChunkRefs).Observe(float64(initialChunkCount))
Expand Down
2 changes: 1 addition & 1 deletion pkg/logql/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ func RecordRangeAndInstantQueryMetrics(
// This is only logged from the querier component, not from the frontend
// (where stats are merged and this value would be inaccurate)
if !isFrontendContext(ctx) && stats.Index.TotalStreams > 0 {
logValues = append(logValues, "total_stream_count", stats.Index.TotalStreams)
logValues = append(logValues, "index_total_streams", stats.Index.TotalStreams)
}

// Add frontend-specific metrics: approximate result size, streams count, lines count
Expand Down