fix(deps): Update go.opentelemetry.io/collector/pdata to v1.60.0 (main)#21744
Conversation
ℹ️ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
005af39 to
91114dc
Compare
433ebe0 to
84e3b97
Compare
899f99d to
b3efde4
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Missing nil check causes panic on missing config
- Restored the missing certificate provider config map lookup guard so absent instances return a descriptive error instead of panicking.
Or push these changes by commenting:
@cursor push 89ac98bfc3
Preview (89ac98bfc3)
diff --git a/vendor/google.golang.org/grpc/internal/xds/balancer/clusterimpl/clusterimpl.go b/vendor/google.golang.org/grpc/internal/xds/balancer/clusterimpl/clusterimpl.go
--- a/vendor/google.golang.org/grpc/internal/xds/balancer/clusterimpl/clusterimpl.go
+++ b/vendor/google.golang.org/grpc/internal/xds/balancer/clusterimpl/clusterimpl.go
@@ -297,7 +297,13 @@
}
func buildProviderFunc(configs map[string]*certprovider.BuildableConfig, instanceName, certName string, wantIdentity, wantRoot bool) (certprovider.Provider, error) {
- cfg := configs[instanceName]
+ cfg, ok := configs[instanceName]
+ if !ok {
+ // Defensive programming. If a resource received from the management
+ // server contains a certificate provider instance name that is not
+ // found in the bootstrap, the resource is NACKed by the xDS client.
+ return nil, fmt.Errorf("xds: certificate provider instance %q not found in bootstrap file", instanceName)
+ }
provider, err := cfg.Build(certprovider.BuildOptions{
CertName: certName,
WantIdentity: wantIdentity,You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit b3efde4. Configure here.
|
|
||
| func buildProviderFunc(configs map[string]*certprovider.BuildableConfig, instanceName, certName string, wantIdentity, wantRoot bool) (certprovider.Provider, error) { | ||
| cfg := configs[instanceName] | ||
| provider, err := cfg.Build(certprovider.BuildOptions{ |
There was a problem hiding this comment.
Missing nil check causes panic on missing config
High Severity
The buildProviderFunc in clusterimpl removed the nil-safety check that existed in the original version in cdsbalancer. The old code used cfg, ok := configs[instanceName] and returned a descriptive error if ok was false. The new code does cfg := configs[instanceName] without checking whether the key exists. If instanceName is absent from configs, cfg will be nil, and calling cfg.Build(...) on the next line will cause a nil pointer dereference panic.
Reviewed by Cursor Bugbot for commit b3efde4. Configure here.
6ca1811 to
30d41f4
Compare
b8c63c5 to
ff7923a
Compare
ff7923a to
678f876
Compare
678f876 to
70a9170
Compare
| datasource | package | from | to | | ---------- | ----------------------------------- | ------- | ------- | | go | go.opentelemetry.io/collector/pdata | v1.56.0 | v1.60.0 | Signed-off-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com>
70a9170 to
1695574
Compare



This PR contains the following updates:
v1.56.0→v1.60.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
open-telemetry/opentelemetry-collector (go.opentelemetry.io/collector/pdata)
v1.60.0🛑 Breaking changes 🛑
cmd/builder: The--skip-get-modulesflag will no longer regenerate yourgo.modfile. (#15390)This is mostly a bug fix, as it led to adverse behaviour that was unintended in the described flow in the README.
Now when you run
--skip-get-modules, yourgo.modfile will truly be untouched byocbas the info log claims.💡 Enhancements 💡
pkg/config/configtls: Addinclude_insecure_cipher_suitesto configtls to enable insecure cipher suites. Insecure cipher suites are disabled by default for security. (#13829)pkg/confighttp: AddExposedHeadersfield toCORSConfigto allow setting theAccess-Control-Expose-Headersresponse header. (#15119)🧰 Bug fixes 🧰
cmd/mdatagen: Removes the extra line in the README.md between status and description (#15306)pkg/exporterhelper: Fix nil-pointer panic insending_queue::batchUnmarshal whensending_queue::sizeris set andsending_queue::batch::enabledis false. (#14687)When
sending_queue::sizerwas set andsending_queue::batch::enabled: falsecleared the batch Optional to None, the sizer-inheritance branch in
queuebatch.Config.Unmarshaldereferenced a nil Optional and crashed thecollector at startup. The branch now also requires
Batch.HasValue().v1.59.0🛑 Breaking changes 🛑
pkg/configoptional: Stabilize feature gate configoptional.AddEnabledField (#15333)pkg/confmap: Stabilize confmap.newExpandedValueSanitizer feature gate (#15339)pkg/exporterhelper: mark exporter.PersistRequestContext as stable (#15330)pkg/otelcol: Stabilize otelcol.printInitialConfig gate (#15340)pkg/pdata: Remove pdata.useCustomProtoEncoding feature gate (#15332)pkg/service: Stabilize telemetry.UseLocalHostAsDefaultMetricsAddress gate (#15342)pkg/xpdata: Stabilize pdata.enableRefCounting feature gate (#15331)🧰 Bug fixes 🧰
pkg/config/configgrpc: Fix memory corruption and fatal error in Snappy (#15237, #15320)v1.58.0💡 Enhancements 💡
pkg/exporterhelper: Addotelcol_exporter_in_flight_requestsmetric to track the number of export requests currently in-flight per exporter. (#15009)This UpDownCounter increments in startOp and decrements in endOp, allowing operators to monitor
concurrent export activity and detect when an exporter is saturating its worker pool.
🧰 Bug fixes 🧰
pkg/confighttp: Close the original request body after reading block-formatContent-Encoding: snappyrequests. (#15262)pkg/confighttp: Recover from panics in decompression libraries, return HTTP 400 instead of 500. (#13228)pkg/confighttp: Enforcemax_request_body_sizeonContent-Encoding: snappyrequests before the decoded buffer is allocated. (#15252)pkg/otelcol: Stop emitting verbose gRPC transport messages at WARN during normal client disconnect. (#5169)grpc-go gates chatty per-RPC notices (e.g. "HandleStreams failed to read frame:
connection reset by peer") behind
LoggerV2.V(2). zapgrpc.Logger.V conflatesgrpclog verbosity with zap severity, so V(2) returns true whenever WARN is
enabled and these messages emit at WARN. Wrap the installed grpclog.LoggerV2
with a corrected V() that compares against a fixed verbosity threshold,
matching grpclog's intended semantics. See uber-go/zap#1544.
pkg/pdata:pcommon.Value.AsStringno longer HTML-escapes<,>, and&insideValueTypeMapandValueTypeSlicevalues, matching the behavior already used forValueTypeStr. (#14662)pkg/service: Fix Prometheus config defaults mismatch when host is explicitly set in telemetry configuration. (#13867)When users explicitly configured the telemetry metrics section (e.g. to change the host),
the Prometheus exporter boolean fields (WithoutScopeInfo, WithoutUnits, WithoutTypeSuffix)
defaulted to nil/false instead of true, causing metric name format changes compared to the
implicit default configuration. This fix applies the correct defaults during config unmarshaling.
pkg/service: Return noop tracer provider when no trace processors are defined (#15135)v1.57.0🛑 Breaking changes 🛑
cmd/builder: In the generated Collector source, thereplacestatements in the Go module will now use relative paths by default. (#15097)We expect that this will not break existing use-cases where the generated collector is only used in an interim manner for builds. It enables the possibility of tracking the generated Collector code as a longer living artifact, allowing it to be run on any machine (whereas absolute paths will be different depending on the machine the Collector source is generated on.) We have added
dist::use_absolute_replace_pathsto go back to the absolute path behaviour in the case where there is an unforeseen use-case that requires absolute paths.pkg/confighttp: Stabilize framedSnappy feature gate. (#15096)💡 Enhancements 💡
all: Add declarative schema support for service telemetry resource configuration. (#14411)The
service::telemetry::resourceconfiguration now accepts the declarative schema with explicit name/value pairs:The legacy inline attribute map format is still supported for backward compatibility:
Note:
resource.detectorsis accepted for forward compatibility but is not yet applied by the collector.exporter/otlp_grpc: Added theserver.addressandurl.pathattributes to metrics generated by the otlp exporter. (#14998)exporter/otlp_http: Added theserver.addressandurl.pathattributes to metrics generated by the otlp_http exporter. (#14998)pkg/config/configgrpc: AddUserAgentfield toClientConfigto allow overriding the default gRPC user-agent string. (#14686)The otlp gRPC exporter was unconditionally setting the User-Agent via
grpc.WithUserAgent() at dial time, which takes precedence over per-call
metadata, causing any user-configured User-Agent to be silently discarded.
A dedicated
UserAgentfield has been added toClientConfigwhich, whenset, is used in the dial option directly instead of the default BuildInfo-derived string.
pkg/config/configgrpc: Accept gRPC resolver scheme URIs in client endpoint (e.g. passthrough:///host:port) to allow control over name resolution (#14990)After the migration to grpc.NewClient, some gRPC client components such as the OTLP
exporter experienced connection issues in dual-stack DNS environments. This can now be
fixed by using the passthrough:/// gRPC resolver scheme in the endpoint field.
pkg/config/confignet: Add support for Windows Named Pipe (npipe) transport (#15085)pkg/service: Emit a warning when using the old v0.2.0 declarative config format (#15088)🧰 Bug fixes 🧰
pkg/otelcol: Print components exactly once in theotelcol componentscommand (#14682)This resolves an issue where aliased components were skipped.
pkg/otelcol: Synchronize Collector Run and Shutdown lifecycles so that Shutdown blocks until Run completes all cleanup. (#4947)Shutdown now blocks until Run finishes cleanup, matching http.Server semantics.
If Shutdown is called before Run, the next Run call returns nil after cleaning up
the config provider.
pkg/pdata: Use spec-compliant string representation for NaN, Infinity, and -Infinity in Value.AsString(). (#14487)pkg/pprofile: Fix data corruption of resource and scope attributes after marshal-unmarshal-merge round-trip. (#15084)pkg/service: Non-string resource attributes in telemetry configuration now return an error instead of panicking (#15171)pkg/xscraperhelper: fix the merge of profiles in the profiling scraper helpers (#14790)receiver/otlp: Fix profiles receiver reporting its samples as spans (#15089)Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
Need help?
You can ask for more help in the following Slack channel: #proj-renovate-self-hosted. In that channel you can also find ADR and FAQ docs in the Resources section.