-
Notifications
You must be signed in to change notification settings - Fork 159
chore: add MCPB manifest #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
Some notes from a conversation with @sd2k: Two separate requirements:
If we want to add it as a Docker image we need to build and tag our image, but the problem is that our Docker image isn't built by our repo but by Docker's mcp-registry repo. We can update our Dockerfile to include the required label (
Once that is done & merged, we can add a server.json which uses the MCPB as mentioned in these requirements. But this approach has an issue that our server is a Go binary so needs the platform specified but that isn't supported by MCPB yet (see this and this). Using Node.js approach sounds like a bad idea, the alternative is to wait for MCPB to support platform-specific builds. Using our own Docker image published to the Docker hub is another option. |
97ad92e
to
ce7a739
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@sd2k and @okianus we now have our own docker image with the label required to publish to the mcp registry. This should be good to go! Have a look and let me know! |
Hm I think we can use the custom Docker image for the server.json but not for the MCPB manifest? Let's chat on Monday |
Addresses #290.