feat: add ds query tool, and update dashboard query extraction for more#357
feat: add ds query tool, and update dashboard query extraction for more#357kissghosts wants to merge 1 commit intografana:mainfrom
Conversation
sd2k
left a comment
There was a problem hiding this comment.
Thanks for adding this. I think it is absolutely the right direction for queries, to be honest, rather than us adding custom tools for every datasource.
My concern is that there is no programmatically obtainable registry of schemas for queries, so it's up to the LLM to guess / figure this out, which isn't great. What I'd really like to do is work with the Grafana plugins folks and make it possible for datasources to expose a JSONSchema for their query objects, so we can provide that to the LLM alongside the 'list datasources' tool or something similar. Until then I fear this tool would fail often for more obsure datasources, and be less effective than dedicated ones for Prometheus/Loki/Tempo.
Have you been running this version at all? Have you found it to work well? Perhaps we could get some end-to-end tests in to see how well it works for different models, datasources and queries. (We need to fix our e2e tests first though 😞 )
Add Custom Datasource Query Tool with Raw Data Support
Key Changes:
QueryMetricsWithExpressionsWithParamsmethod ingrafana-openapi-client-goonly returns metadata information without the actual monitoring data.