fix: remove redundant transport middleware in Graphite client#778
Merged
Conversation
The Graphite tools PR (#741) was based on code before the transport refactor (#771) which consolidated middleware into BuildTransport(). This caused a compilation error due to the removed NewAuthRoundTripper function, and also redundantly applied OrgID and UserAgent middleware that BuildTransport() already handles. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
MCP Token Analysis✅ Passed
|
kolesnikovae
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewAuthRoundTripperbeing removed.NewAuthRoundTripper,NewOrgIDRoundTripper, andNewUserAgentTransportcalls thatBuildTransport()already handles internally.Test plan
go build ./...passesgo vet ./...passes🤖 Generated with Claude Code
Note
Medium Risk
Touches outbound HTTP transport construction for Graphite queries; if
mcpgrafana.BuildTransportdoesn’t apply the same auth/org/user-agent behavior in all deployments, requests could fail or change routing, but the change is small and intended to fix a build break.Overview
Removes redundant HTTP transport wrappers in the Graphite client (
NewAuthRoundTripper,NewOrgIDRoundTripper, andNewUserAgentTransport) and relies solely onmcpgrafana.BuildTransportfor those concerns.Keeps the existing datasource fallback behavior by wrapping the built transport only with
newDatasourceFallbackTransport, fixing compilation after the upstream transport refactor.Reviewed by Cursor Bugbot for commit 6714878. Bugbot is set up for automated code reviews on this repo. Configure here.