Refactor metrictank repo to be compatible with go modules #2042
Conversation
ywwg
force-pushed
the
owilliams/gofixes2
branch
from
df95a3d to
c87cb62
Compare
ywwg
force-pushed
the
owilliams/gofixes2
branch
from
1b21e43 to
a123880
Compare
ywwg
force-pushed
the
owilliams/gofixes2
branch
3 times, most recently
from
1254c68 to
731321a
Compare
| fmt.Fprintln(os.Stderr, "It is up to you to assure table-out exists before running this tool") | ||
| fmt.Fprintln(os.Stderr, "This tool is EXPERIMENTAL and needs doublechecking whether data is successfully written to Cassandra") | ||
| fmt.Fprintln(os.Stderr, "see https://github.com/grafana/metrictank/pkg/pull/909 for details") | ||
| fmt.Fprintln(os.Stderr, "see https://github.com/grafana/metrictank/pull/909 for details") |
There was a problem hiding this comment.
this was a find-replace error
| // and singles in groups by retention (in schemaID order) | ||
| // * PNGroups obviously will need a common interval, which gets interesting when using multiple schemas | ||
| // * coarsening continues until all data is fetched at its coarsest. At that point we may breach soft, but never hard | ||
| // - requests are coarsened, PNGroup by PNGroup (we cannot predict PNGroup map iteration order, so we only test with 1 PNGroup), |
There was a problem hiding this comment.
the new gofmt does different things
pkg/api/query_engine.go
Outdated
|
|
||
| // Note: MDP-yes code path may not take into account that archive 0 may have a different raw interval. | ||
| // see https://github.com/grafana/metrictank/issues/1679 | ||
| // see https://github.com/grafana/metrictank/pkg/issues/1679 |
|
I think to fix the pointed out search & replace issue the easiest would be to just search and replace these strings: github.com/grafana/metrictank/pkg/blob and remove the |
ywwg
force-pushed
the
owilliams/gofixes2
branch
from
731321a to
aeba5bd
Compare
|
ok I rolled the deps back that I could get from gopkg.lock, but unfortunately there are still massive diffs between the checked-in vendor/ dir in metrictank and the versions created by I think the next step is figuring out a way to test this branch to see if any of the module updates break anything. |
|
due to the risk of instability, we are going to put off merging this until ~Q1 or so. |
2 participants
This PR refactors the entire metrictank repository to make it compatible with Go modules as well with vscode's static compilation. All of the Makefile commands have been fixed (as far as I know). I believe travis/circleci is also working.
As part of the change, the vendor/ directory has been removed from checked-in source, instead users should run
go mod vendorlocally as needed.