Skip to content

Conversation

@mimir-github-bot
Copy link
Contributor

@mimir-github-bot mimir-github-bot bot commented Nov 27, 2025

Merge from prometheus/prometheus

This PR was automatically created by the merge-upstream-prometheus workflow

Details:

Changes:

This PR merges the latest changes from the upstream prometheus/prometheus main branch.


Note

Normalizes histogramRate to always return Gauge-type histograms (with tests), stops label completions after closing matcher in the editor, re-enables/improves remote-write resharding test, and aligns schema label handling with common model constants.

  • PromQL:
    • Normalize histogramRate(...) to set CounterResetHint to GaugeType before returning in promql/functions.go.
    • Add tests validating the hint (promql/functions_internal_test.go).
  • UI (CodeMirror PromQL autocomplete):
    • In web/ui/module/.../hybrid.ts, avoid label suggestions when cursor is outside LabelMatchers (e.g., just after }); add corresponding test case in hybrid.test.ts.
  • Tests:
    • Re-enable and harden TestRemoteWrite_ReshardingWithoutDeadlock in cmd/prometheus/main_test.go (tweaked scrape interval, queue config, debug logging, helper to fetch metrics, and explicit checks for initial and scaled desired shards).
  • Schema/Labels:
    • Switch to github.com/prometheus/common/model label constants (MetricNameLabel, MetricTypeLabel, MetricUnitLabel) across schema/labels.go and its tests; clarify deprecation comment in model/labels/labels_common.go.
  • Docs/Comments:
    • Minor comment tweaks (e.g., promql/engine.go, storage/interface.go).

Written by Cursor Bugbot for commit 0a3069d. This will update automatically on new commits. Configure here.

bwplotka and others added 8 commits November 24, 2025 08:31
…lete

[BUGFIX] UI: Fixed codemirror-promql incorrectly showing label completion suggestions
The original implementation in #9705 for native histograms included a
technical dept #15177 where samples were committed ordered by type
not by their append order. This was fixed in #17071, but this docstring
was not updated.

I've also took the liberty to mention that we do not order by timestamp
either, thus it is possible to append out of order samples.

Signed-off-by: György Krajcsovits <[email protected]>
…le and re-enable it (#17490)

Improve test stability by waiting for the relevant metrics to appear on /metrics before the
first check on the desired shard count.

Increase the scrape interval to avoid timeouts, as 100 ms may be insufficient for Prometheus
to scrape itself in some environments (e.g., CI).

Have Prometheus scrape itself multiple times to increase the volume of data sent and help
fill the queue more quickly.

Signed-off-by: machine424 <[email protected]>
…n a gauge histogram. (#17608)

Signed-off-by: Andrew Hall <[email protected]>
Copy link
Contributor

@mimir-vendoring mimir-vendoring bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this upstream merge PR.
This PR merges changes from prometheus/prometheus upstream repository.
Related GitHub action is defined here.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 8 committers have signed the CLA.

✅ tcp13equals2
✅ krajorama
❌ bwplotka
❌ ADITYATIWARI342005
❌ juliusv
❌ faustuzas
❌ machine424
❌ mimir-github-bot[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@mimir-vendoring mimir-vendoring bot enabled auto-merge November 27, 2025 06:44
@mimir-vendoring mimir-vendoring bot merged commit d4cdacd into main Nov 27, 2025
31 of 32 checks passed
@mimir-vendoring mimir-vendoring bot deleted the bot/main/merge-upstream-main-202511270643 branch November 27, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants