-
Notifications
You must be signed in to change notification settings - Fork 10
Clean up disk for "More Go tests" #1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
`TestCompaction_CompactWithSplitting` is consistently failing on my branches with `preallocate: no space left on device` example https://github.com/grafana/mimir-prometheus/actions/runs/20029126858/job/57433565471#step:6:450
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses disk space issues in the "More Go tests" CI workflow by enabling disk cleanup before test execution. The change specifically targets failures of TestCompaction_CompactWithSplitting which consistently fails with "preallocate: no space left on device" errors in this fork.
- Enables the
clean-runner-diskparameter for the promci setup_environment action - Adds explanatory comments noting this is a fork-specific fix not present upstream
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/ci.yml
Outdated
| - uses: prometheus/promci@443c7fc2397e946bc9f5029e313a9c3441b9b86d # v0.4.7 | ||
| - uses: ./.github/promci/actions/setup_environment | ||
| with: | ||
| # For some reason a compactor test fails by running out of disk. |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The comment "For some reason a compactor test fails by running out of disk" is vague. Consider being more specific about which test is failing. Based on the PR description, this should reference TestCompaction_CompactWithSplitting.
Suggested improvement:
# TestCompaction_CompactWithSplitting fails by running out of disk space.| # For some reason a compactor test fails by running out of disk. | |
| # TestCompaction_CompactWithSplitting fails by running out of disk space. |
|
welp, this doesn't fix it |
.github/workflows/ci.yml
Outdated
| with: | ||
| # For some reason a compactor test fails by running out of disk. | ||
| # This isn't present upstream, but it's helping here. | ||
| clean-runner-disk: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Version mismatch causes clean-runner-disk option to fail
The test_go_more job uses prometheus/[email protected] but attempts to use the clean-runner-disk: true parameter with setup_environment. The test_go job was updated to use promci v0.5.3, which likely introduced the clean-runner-disk feature. Since test_go_more still references v0.4.7, the clean-runner-disk parameter may not be recognized or functional, explaining why the author's comment says "welp, this doesn't fix it". The promci version at line 39 needs to match v0.5.3 for the new option to work.
197ada7 to
fbd0bdb
Compare
TestCompaction_CompactWithSplittingis consistently failing on my branches withpreallocate: no space left on deviceexample https://github.com/grafana/mimir-prometheus/actions/runs/20029126858/job/57433565471#step:6:450
Which issue(s) does the PR fix:
Does this PR introduce a user-facing change?
Note
Upgrade promci for
test_goand enable disk cleanup intest_go_moreto mitigate space issues..github/workflows/ci.yml):test_go:prometheus/promcitov0.5.3.setup_environmentNPM options.test_go_more:clean-runner-disk: truetosetup_environmentto free disk space.Written by Cursor Bugbot for commit 197ada7. This will update automatically on new commits. Configure here.