Skip to content

Conversation

@dimitarvdimitrov
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov commented Dec 8, 2025

Remove unused postings_sketches code. The Statistics interface and LabelsValuesSketches are only used in mimir where they're redefined.

Related to


Note

Removes the postings sketches implementation and tests, and cleans up associated dependencies.

  • Index/TSDB:
    • Remove tsdb/index/postings_sketches.go and tsdb/index/postings_sketches_test.go (count-min sketch–based Statistics implementation).
  • Dependencies:
    • Drop github.com/tylertreat/BoomFilters and github.com/d4l3k/messagediff from go.mod; prune corresponding go.sum entries.

Written by Cursor Bugbot for commit db4ff56. This will update automatically on new commits. Configure here.

@dimitarvdimitrov dimitarvdimitrov marked this pull request as ready for review December 8, 2025 18:01
@dimitarvdimitrov dimitarvdimitrov merged commit 4604607 into main Dec 8, 2025
31 checks passed
@dimitarvdimitrov dimitarvdimitrov deleted the dimitar/index/remove-postings-sketches branch December 8, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants