Skip to content

Conversation

@renovate-sh-app
Copy link
Contributor

@renovate-sh-app renovate-sh-app bot commented Oct 13, 2025

This PR contains the following updates:

Package Type Update Change
github.com/grafana/alerting (changelog) require digest d513d62 -> 5c84f76

Warning

Some dependencies could not be looked up. Check the warning logs for more information.


Configuration

📅 Schedule: Branch creation - Between 12:00 AM and 04:59 AM, only on Monday ( * 0-4 * * 1 ) (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

Need help?

You can ask for more help in the following Slack channel: #proj-renovate-self-hosted. In that channel you can also find ADR and FAQ docs in the Resources section.

@renovate-sh-app renovate-sh-app bot requested a review from a team as a code owner October 13, 2025 00:08
@renovate-sh-app renovate-sh-app bot requested review from a team and stevesg as code owners October 13, 2025 00:08
@CLAassistant
Copy link

CLAassistant commented Oct 13, 2025

CLA assistant check
All committers have signed the CLA.

@renovate-sh-app renovate-sh-app bot force-pushed the deps-update/main-github.com-grafana-alerting-digest branch 5 times, most recently from f7cf5d3 to 87b7337 Compare October 24, 2025 18:11
@renovate-sh-app renovate-sh-app bot changed the title fix(deps): update github.com/grafana/alerting digest to 9427c24 (main) fix(deps): update github.com/grafana/alerting digest to 6ed8507 (main) Oct 24, 2025
@renovate-sh-app renovate-sh-app bot changed the title fix(deps): update github.com/grafana/alerting digest to 6ed8507 (main) fix(deps): update github.com/grafana/alerting digest to e56041d (main) Oct 28, 2025
@renovate-sh-app renovate-sh-app bot force-pushed the deps-update/main-github.com-grafana-alerting-digest branch 2 times, most recently from 8cc2937 to 2abb899 Compare October 28, 2025 21:10
@renovate-sh-app renovate-sh-app bot changed the title fix(deps): update github.com/grafana/alerting digest to e56041d (main) fix(deps): update github.com/grafana/alerting digest to a338784 (main) Oct 28, 2025
@renovate-sh-app renovate-sh-app bot changed the title fix(deps): update github.com/grafana/alerting digest to a338784 (main) fix(deps): update github.com/grafana/alerting digest to 2346e4d (main) Oct 29, 2025
@renovate-sh-app renovate-sh-app bot force-pushed the deps-update/main-github.com-grafana-alerting-digest branch from 2abb899 to de4608f Compare October 29, 2025 00:11
@renovate-sh-app
Copy link
Contributor Author

renovate-sh-app bot commented Oct 29, 2025

ℹ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 3 additional dependencies were updated

Details:

Package Change
github.com/prometheus/alertmanager v0.28.1 -> v0.28.2
github.com/at-wat/mqtt-go v0.19.4 -> v0.19.6
github.com/go-openapi/runtime v0.27.1 -> v0.28.0

@renovate-sh-app renovate-sh-app bot force-pushed the deps-update/main-github.com-grafana-alerting-digest branch from de4608f to feb456a Compare October 30, 2025 18:09
@renovate-sh-app renovate-sh-app bot changed the title fix(deps): update github.com/grafana/alerting digest to 2346e4d (main) fix(deps): update github.com/grafana/alerting digest to 64c16bb (main) Oct 30, 2025
@renovate-sh-app renovate-sh-app bot force-pushed the deps-update/main-github.com-grafana-alerting-digest branch 2 times, most recently from 4df4f5e to 4118877 Compare October 31, 2025 18:09
@renovate-sh-app renovate-sh-app bot force-pushed the deps-update/main-github.com-grafana-alerting-digest branch from 4118877 to a0638c3 Compare November 7, 2025 12:16
@renovate-sh-app renovate-sh-app bot changed the title fix(deps): update github.com/grafana/alerting digest to 64c16bb (main) fix(deps): update github.com/grafana/alerting digest to fc62a7f (main) Nov 7, 2025
@renovate-sh-app renovate-sh-app bot force-pushed the deps-update/main-github.com-grafana-alerting-digest branch 2 times, most recently from a5489b2 to a294fd6 Compare November 10, 2025 15:13
@renovate-sh-app renovate-sh-app bot changed the title fix(deps): update github.com/grafana/alerting digest to fc62a7f (main) fix(deps): update github.com/grafana/alerting digest to 4b965be (main) Nov 10, 2025
@renovate-sh-app renovate-sh-app bot changed the title fix(deps): update github.com/grafana/alerting digest to 4b965be (main) fix(deps): update github.com/grafana/alerting digest to 3befd25 (main) Nov 10, 2025
@renovate-sh-app renovate-sh-app bot force-pushed the deps-update/main-github.com-grafana-alerting-digest branch from a294fd6 to 26a729d Compare November 10, 2025 21:16
newName := getUniqueName(cpy.Name, suffix, usedNames)
renames[cpy.Name] = newName
cpy.Name = newName
usedNames[cpy.Name] = i
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Flawed Renaming Logic Causes Conflict Errors

In MergeReceivers, after renaming a receiver, the code sets usedNames[cpy.Name] = i but i refers to the index of the conflicting item that triggered the rename, not the current item's index. This should be usedNames[cpy.Name] = idx to correctly track which incoming receiver now has this name. This can cause incorrect conflict detection for subsequent receivers with the same name, potentially leading to missed renames or incorrect renaming behavior when multiple incoming receivers share the same original name.

Fix in Cursor Fix in Web

@renovate-sh-app renovate-sh-app bot force-pushed the deps-update/main-github.com-grafana-alerting-digest branch 2 times, most recently from 3c4ede0 to 9675026 Compare November 17, 2025 06:13
@renovate-sh-app renovate-sh-app bot changed the title fix(deps): update github.com/grafana/alerting digest to 3befd25 (main) fix(deps): update github.com/grafana/alerting digest to 77fa751 (main) Nov 19, 2025
@renovate-sh-app renovate-sh-app bot force-pushed the deps-update/main-github.com-grafana-alerting-digest branch 2 times, most recently from 57c3620 to 4cf0f3f Compare November 25, 2025 18:46
Route: route,
InhibitRules: inhibitRules,
MuteTimeIntervals: mergedMuteTime,
MuteTimeIntervals: a.MuteTimeIntervals,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: MergeTimeIntervals loses incoming mute time intervals

The MergeTimeIntervals function signature was changed to return only ([]config.TimeInterval, map[string]string) instead of ([]config.MuteTimeInterval, []config.TimeInterval, map[string]string). However, the result now uses a.MuteTimeIntervals directly instead of the merged mute time intervals. This causes incoming mute time intervals from configuration b to be silently dropped during the merge, breaking alert routing configurations that depend on mute time intervals from the secondary configuration.

Additional Locations (1)

Fix in Cursor Fix in Web

@renovate-sh-app renovate-sh-app bot force-pushed the deps-update/main-github.com-grafana-alerting-digest branch 2 times, most recently from 7b144e8 to 6b3ae36 Compare November 29, 2025 16:33
@renovate-sh-app renovate-sh-app bot changed the title fix(deps): update github.com/grafana/alerting digest to 77fa751 (main) fix(deps): update github.com/grafana/alerting digest to 2a1ab8c (main) Nov 29, 2025
@renovate-sh-app renovate-sh-app bot force-pushed the deps-update/main-github.com-grafana-alerting-digest branch from 6b3ae36 to cf3bfcf Compare December 1, 2025 10:45
@renovate-sh-app renovate-sh-app bot changed the title fix(deps): update github.com/grafana/alerting digest to 2a1ab8c (main) fix(deps): update github.com/grafana/alerting digest to f01c986 (main) Dec 1, 2025
@renovate-sh-app renovate-sh-app bot force-pushed the deps-update/main-github.com-grafana-alerting-digest branch from cf3bfcf to b774f8e Compare December 1, 2025 22:35
@renovate-sh-app renovate-sh-app bot changed the title fix(deps): update github.com/grafana/alerting digest to f01c986 (main) fix(deps): update github.com/grafana/alerting digest to 218187f (main) Dec 1, 2025
@renovate-sh-app renovate-sh-app bot force-pushed the deps-update/main-github.com-grafana-alerting-digest branch from b774f8e to 02419f9 Compare December 2, 2025 16:23
@renovate-sh-app renovate-sh-app bot changed the title fix(deps): update github.com/grafana/alerting digest to 218187f (main) fix(deps): update github.com/grafana/alerting digest to 58fa500 (main) Dec 2, 2025
v.Grow(len(csvWriter.records))
v.SetCap(len(csvWriter.records)) // in case Grow was unnessary, trim down the capacity
v.SetLen(len(csvWriter.records))
reflect.Copy(v, reflect.ValueOf(csvWriter.records))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: CSV unmarshal panics when destination slice has existing elements

The refactored CSV unmarshaling code calls v.SetCap(len(csvWriter.records)) before resetting the slice length. According to Go's reflect documentation, SetCap panics if n is smaller than the current length of the slice. If a caller passes a destination slice that already contains more elements than the incoming CSV records, this will panic. The previous implementation correctly handled this by calling v.SetLen(0) first, then using AppendSlice to populate the data. This is a regression that could cause runtime panics in edge cases where pre-populated slices are reused.

Fix in Cursor Fix in Web

@renovate-sh-app renovate-sh-app bot force-pushed the deps-update/main-github.com-grafana-alerting-digest branch from 02419f9 to 072ae37 Compare December 4, 2025 16:33
@renovate-sh-app renovate-sh-app bot changed the title fix(deps): update github.com/grafana/alerting digest to 58fa500 (main) fix(deps): update github.com/grafana/alerting digest to de8c2bb (main) Dec 4, 2025
}

return result, renamed
return usedNames
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing nil check causes potential panic in receivers merge

The new createIndexReceivers function accesses .Name on receivers without checking if they're nil. Both loops iterate over existing and incoming slices of pointers, but unlike the calling function MergeReceivers which checks if r == nil, this helper function directly accesses e.Name (line 356) and i.Name (line 359-360). If either slice contains a nil entry, this causes a nil pointer dereference panic.

Fix in Cursor Fix in Web

s.Versions[i].typeSchema = &s
}
return s
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: InitSchema returns struct with dangling pointer references

The InitSchema function receives the schema by value, sets typeSchema pointers on each version to point to the local variable &s, then returns s by value. After the function returns, the typeSchema pointers in the returned struct's Versions still reference the function's stack-local copy of s, which becomes invalid memory. Any subsequent call to GetTypeSchema() or Type() on a version will dereference a dangling pointer, causing undefined behavior or crashes.

Fix in Cursor Fix in Web

@renovate-sh-app renovate-sh-app bot force-pushed the deps-update/main-github.com-grafana-alerting-digest branch 3 times, most recently from ac6a144 to 6633eda Compare December 9, 2025 10:43
if _, err := notifier.Notify(ctx, &testAlert); err != nil {
return err
}
return nil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Test notifications use integration type instead of receiver name

The TestNotifier function sets context values using notifier.Name(), which returns the integration type (e.g., "slack", "email") rather than the receiver's configured name. The previous implementation used next.ReceiverName from the job struct, which contained the actual receiver name. This causes the group key format and receiver name in context to differ from before, affecting notification history recording which will now show integration types instead of meaningful receiver names. The function lacks a receiverName parameter to preserve the original behavior.

Fix in Cursor Fix in Web

@renovate-sh-app renovate-sh-app bot force-pushed the deps-update/main-github.com-grafana-alerting-digest branch 2 times, most recently from f46c845 to d29c598 Compare December 11, 2025 13:22
@renovate-sh-app renovate-sh-app bot changed the title fix(deps): update github.com/grafana/alerting digest to de8c2bb (main) fix(deps): update github.com/grafana/alerting digest to 3c37712 (main) Dec 11, 2025
var elem any
item := sliceVal.Index(j)
if elemType.Kind() == reflect.Ptr {
elem = item.Elem().Interface()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Reflection panic on nil pointer in slice elements

In ConfigReceiverToMimirIntegrations, when processing slices of pointer types (e.g., []*EmailConfig), the code calls item.Elem().Interface() without checking if item represents a nil pointer. If a slice contains a nil element, item.Elem() returns an invalid reflect.Value, and calling Interface() on it will panic with "reflect: call of reflect.Value.Interface on zero Value".

Fix in Cursor Fix in Web

Signed-off-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com>
@renovate-sh-app renovate-sh-app bot force-pushed the deps-update/main-github.com-grafana-alerting-digest branch from d29c598 to 7f0563b Compare December 12, 2025 04:25
@renovate-sh-app renovate-sh-app bot changed the title fix(deps): update github.com/grafana/alerting digest to 3c37712 (main) fix(deps): update github.com/grafana/alerting digest to 5c84f76 (main) Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant