compactor: verify that TSDB uploads use index format v2 #13815
+96
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verify that the TSDB block index file uses v2 for the file format, not v1. The v1 format was only used for Prometheus 2.0 and 2.1 as far as I can tell. It hasn't been the default format for new blocks since Prometheus 2.2 and has never been the default for Mimir. Part of #13808
56quarters
force-pushed
the
56quarters/index-upload
branch
from
8108c6d to
2477fd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Verify that the TSDB block index file uses v2 for the file format, not v1. The v1 format was only used for Prometheus 2.0 and 2.1 as far as I can tell. It hasn't been the default format for new blocks since Prometheus 2.2 and has never been the default for Mimir.
Which issue(s) this PR fixes or relates to
Part of #13808
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.Note
Enforces v2 TSDB index format on uploaded blocks by validating index version during health checks, adds tests, and updates the changelog.
HealthStats.IndexFormatandUnsupportedIndexFormat(); onlyv2(index.FormatV2) is accepted viaSupportedIndexFormats.GatherBlockHealthStats()records index file version;AnyErr()now fails on unsupported formats.TestHealthStats_AnyErr).CHANGELOG.md: require uploaded TSDB blocks to use v2 index format.Written by Cursor Bugbot for commit 2477fd9. This will update automatically on new commits. Configure here.