Skip to content

Conversation

@tcp13equals2
Copy link
Contributor

@tcp13equals2 tcp13equals2 commented Dec 12, 2025

What this PR does

This PR updates the default regex used by the zone aware pod disruption budget.

The regex has been updated to support an optional -partition element in the pod name.

eg ingester-zone-a-partition-10 is now supported.

Note that this regex format is confirmed supported and tested in grafana/rollout-operator#349

Which issue(s) this PR fixes or relates to

This alternate pod name format is used within ingest storage upgrade/migration paths. Adding support for this ensures that the rollout-operator continues to function correctly during such migrations.

Checklist

  • Tests updated.
  • Documentation added.
  • [ x] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]. If changelog entry is not needed, please add the changelog-not-needed label to the PR.
  • about-versioning.md updated with experimental features.

Note

Extends ZoneAwarePodDisruptionBudget pod name regex to accept optional -partition segment and updates regex group index, with corresponding changes in defaults and generated tests, plus changelog entry.

  • Rollout Operator / Config:
    • Update default multi_zone_ingester_zpdb_partition_regex to '[a-z\-]+-zone-[a-z]-(partition\-)?([0-9]+)' and multi_zone_ingester_zpdb_partition_group to 2 in operations/mimir/multi-zone-ingester.libsonnet.
  • Generated Tests:
    • Adjust ZoneAwarePodDisruptionBudget specs across generated YAMLs to use new podNamePartitionRegex and podNameRegexGroup (2) for ingester rollouts.
  • Changelog:
    • Add enhancement entry noting regex now supports optional -partition in pod names.

Written by Cursor Bugbot for commit 062afff. This will update automatically on new commits. Configure here.

@tcp13equals2 tcp13equals2 marked this pull request as ready for review December 12, 2025 02:45
@tcp13equals2 tcp13equals2 requested a review from a team as a code owner December 12, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant