Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR updates the default regex used by the zone aware pod disruption budget.
The regex has been updated to support an optional
-partitionelement in the pod name.eg
ingester-zone-a-partition-10is now supported.Note that this regex format is confirmed supported and tested in grafana/rollout-operator#349
Which issue(s) this PR fixes or relates to
This alternate pod name format is used within ingest storage upgrade/migration paths. Adding support for this ensures that the rollout-operator continues to function correctly during such migrations.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.Note
Extends
ZoneAwarePodDisruptionBudgetpod name regex to accept optional-partitionsegment and updates regex group index, with corresponding changes in defaults and generated tests, plus changelog entry.multi_zone_ingester_zpdb_partition_regexto'[a-z\-]+-zone-[a-z]-(partition\-)?([0-9]+)'andmulti_zone_ingester_zpdb_partition_groupto2inoperations/mimir/multi-zone-ingester.libsonnet.ZoneAwarePodDisruptionBudgetspecs across generated YAMLs to use newpodNamePartitionRegexandpodNameRegexGroup(2) for ingester rollouts.-partitionin pod names.Written by Cursor Bugbot for commit 062afff. This will update automatically on new commits. Configure here.