store-gateway: remove support for reading TSDB index v1 #13824
+40
−392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes support for generating index-headers and reading the v1 format of TSDB index files. The v1 format was only the default in Prometheus 2.0 and 2.1. Prometheus 2.2 and later default to creating blocks that use the v2 format. The v1 format has never been the default in Mimir. Note that this change does not refactor or change index-header code beyond removing v1 support. Further cleanups will be done in follow up PRs. Part of #13808 Signed-off-by: Nick Pillitteri <[email protected]>
56quarters
force-pushed
the
56quarters/index-sg
branch
from
d7d7a67 to
938cc96
Compare
francoposa
reviewed
Dec 12, 2025
Contributor
There was a problem hiding this comment.
Do we still want to git-keep this directory?
Contributor
Author
There was a problem hiding this comment.
The chunks directory inside index_format_v1? No, we're removing the test data for the v1 format of the TSDB index unless I'm misunderstanding what you're asking.
Contributor
There was a problem hiding this comment.
Ah the GitHub diff description Whitespace-only changes. made it look like the file still existed - now that I pulled I can see the whole directory's gone.
francoposa
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This change removes support for generating index-headers from and reading the v1 format of TSDB index files. The v1 format was only the default in Prometheus 2.0 and 2.1. Prometheus 2.2 and later default to creating blocks that use the v2 format. The v1 format has never been the default in Mimir.
Note that this change does not refactor or change index-header code beyond removing v1 support. Further cleanups will be done in follow up PRs.
Which issue(s) this PR fixes or relates to
Part of #13808
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.Note
Remove TSDB index v1 support (store-gateway/index-header), simplify code to v2-only, rename sparse helpers, update tests, and add changelog entry.
newChunkedIndexReader()andNewPostingOffsetTable()now accept onlyindex.FormatV2.index/symbols.goand reader logic.NewSparsePostingOffsetTable()→ToSparsePostingOffsetTable(),NewSparseSymbol()→ToSparseSymbols(); update call sites instream_binary_reader.goand tests.PostingOffsetTableV1implementation and related parsing code.Written by Cursor Bugbot for commit 938cc96. This will update automatically on new commits. Configure here.