[WIP] indexheader bucket reader scratch reader benchmark and stats #13825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Right now, collecting the caching bucket stats in this way is not interesting because they are collected after each individual matcher test - if you run the same matcher over and over again you will of course hit the cache well and not have wasted data fetches. What we would want to is run a bunch of different matchers and then collect the caching bucket stats after they all run. |
Contributor
Author
|
Further things to test after getting the more complete benchmark setup:
|
francoposa
force-pushed
the
francoposa/indexheader-bucket-reader-scratch
branch
from
492c9c1 to
38ec762
Compare
…luesOffsetsIndexV2_WithPrefix - TODO separate benchmark & make it more interesting
francoposa
force-pushed
the
francoposa/indexheader-bucket-reader-scratch-decbuf-reader-stats
branch
from
7860176 to
6c80368
Compare
…o reader_benchmarks_test
4 tasks
francoposa
added a commit
that referenced
this pull request
Jan 7, 2026
<!-- Thanks for sending a pull request! Before submitting: 1. Read our CONTRIBUTING.md guide 2. Rebase your PR if it gets out of sync with main --> #### What this PR does Moves existing test fixtures defined in `pkg/storegateway/bucket_test.go` to `pkg/storage/fixtures/fixtures.go`, with some minor cleanup. This makes the same test cases importable in both `pkg/storegateway` and `pkg/storage`, allowing us to re-use the large, complex set of series selector matcher test cases in both packages. This is a preable to bringing in the rest of the indexheader-reader benchmarks from the hackathon branch at #13825. #### Which issue(s) this PR fixes or relates to Fixes #<issue number> #### Checklist - [x] Tests updated. - [ ] Documentation added. - [ ] `CHANGELOG.md` updated - the order of entries should be `[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry is not needed, please add the `changelog-not-needed` label to the PR. - [ ] [`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md) updated with experimental features. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Introduces importable test utilities to simplify and unify TSDB block/test data setup across packages. > > - Adds `pkg/storage/fixtures` with `FsInstrumentedBucket`, `SetupTestBlock`, `AppendTestSeries`, and `SeriesSelectorTestCases` for reusable block creation and matcher cases > - Refactors `storegateway` tests/benchmarks to use fixtures; removes duplicated helpers (`prepareTestBlock`, `appendTestSeries`, `seriesSelectionTestCases`) and `localBucket` > - Adds `testBlockToBucketBlock` adapter to wrap `fixtures.BucketTestBlock` for existing test code > - Updates assertions/paths to use `FsInstrumentedBucket.RootDir()` and shared constants > > Scope limited to test code; no production code changes > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit b911ff3. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.