Add how to opt out of rollout-operator to v5 -> v6 docs #13927
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrading without this leads to a mimir deployment that can no longer be modified. Signed-off-by: Kyle Fazzari <[email protected]>
|
|
tacole02
reviewed
Jan 6, 2026
| Follow the [Migrate to unified proxy deployment](https://grafana.com/docs/helm-charts/mimir-distributed/v5.8.x/migration-guides/migrate-to-unified-proxy-deployment/) guide to complete this migration. | ||
|
|
||
| ### Install rollout-operator CRDs (if using rollout-operator) | ||
| ### Account for the rollout-operator |
Contributor
There was a problem hiding this comment.
Suggested change
| ### Account for the rollout-operator | |
| ### Account for the rollout-operator | |
| If your deployment uses the rollout-operator, you must ensure that the required CustomResourceDefinitions (CRDs) are installed. If you don’t use the rollout-operator, you must explicitly disable it in your values file to avoid unnecessary components. | |
| ### Install rollout-operator CRDs (if using rollout-operator) | ||
| ### Account for the rollout-operator | ||
|
|
||
| #### If using, install CRDs |
Contributor
There was a problem hiding this comment.
Suggested change
| #### If using, install CRDs | |
| #### Install CRDs when using the rollout-operator |
Author
There was a problem hiding this comment.
Done, although I used "if" instead of "when" given that this upgrade only happens once instead of implying some sort of ongoing thing.
| kubectl apply -f https://raw.githubusercontent.com/grafana/helm-charts/main/charts/rollout-operator/crds/zone-aware-pod-disruption-budget-custom-resource-definition.yaml | ||
| ``` | ||
|
|
||
| #### If not using, disable webhooks |
Contributor
There was a problem hiding this comment.
Suggested change
| #### If not using, disable webhooks | |
| #### Disable the rollout-operator when not in use |
Author
There was a problem hiding this comment.
Done, although I used "if" instead of "when" given that this upgrade only happens once instead of implying some sort of ongoing thing.
|
|
||
| #### If not using, disable webhooks | ||
|
|
||
| If you've opted not to use the rollout-operator, disable it in your values file: |
Contributor
There was a problem hiding this comment.
Suggested change
| If you've opted not to use the rollout-operator, disable it in your values file: | |
| If you don’t use the rollout-operator, disable it in your values file to prevent the installation of related webhooks: |
Author
There was a problem hiding this comment.
Done, although I also added the clarification that adding those webhooks without the CRDs will actually interfere with future rollouts. This really is a footgun to ship by default, by the way 😛 .
Signed-off-by: Kyle Fazzari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading without this leads to a mimir deployment that can no longer be modified (e.g. #13928).
Note
Updates the 5.x→6.0 Helm chart migration guide to clarify rollout-operator handling.
rollout_operator.enabled: falseto avoid webhook interference during rolloutsWritten by Cursor Bugbot for commit 0217cbb. This will update automatically on new commits. Configure here.