store-gateway: Extend block load logs to include basic block info#14290
Open
store-gateway: Extend block load logs to include basic block info#14290
Conversation
narqo
approved these changes
Feb 9, 2026
Contributor
narqo
left a comment
There was a problem hiding this comment.
One minor comment, but I agree in spirit 🔥
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
56quarters
reviewed
Feb 12, 2026
Co-authored-by: Nick Pillitteri <56quarters@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This is a tiny change that just adds extra info to the log when a block is loaded during the sync process.
It can answer questions like "how often are we loading L2 blocks," at the point where the blocked is synced instead of needing to wait for a query to touch the block.
It also includes extra general info about the block, so we can get an idea of size and not need to cross reference the ULID against other logs or the bucket.
Which issue(s) this PR fixes or relates to
Supporting https://github.com/grafana/mimir-squad/issues/3373
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.Note
Low Risk
Log-only change that adds extra fields on successful block load; no functional, security, or data-path behavior changes.
Overview
Extends the store-gateway
addBlock()success log line to include basic block metadata when a block is loaded during sync.The
loaded new blocklog now emitscompaction_level,num_series, out-of-order flag (ooo), and the block time range (from/to), improving observability without changing load behavior.Written by Cursor Bugbot for commit d5ab7dc. This will update automatically on new commits. Configure here.