Skip to content

store-gateway: Extend block load logs to include basic block info#14290

Open
alexweav wants to merge 5 commits intomainfrom
alexweav/load-block-logs
Open

store-gateway: Extend block load logs to include basic block info#14290
alexweav wants to merge 5 commits intomainfrom
alexweav/load-block-logs

Conversation

@alexweav
Copy link
Contributor

@alexweav alexweav commented Feb 9, 2026

What this PR does

This is a tiny change that just adds extra info to the log when a block is loaded during the sync process.
It can answer questions like "how often are we loading L2 blocks," at the point where the blocked is synced instead of needing to wait for a query to touch the block.

It also includes extra general info about the block, so we can get an idea of size and not need to cross reference the ULID against other logs or the bucket.

Which issue(s) this PR fixes or relates to

Supporting https://github.com/grafana/mimir-squad/issues/3373

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]. If changelog entry is not needed, please add the changelog-not-needed label to the PR.
  • about-versioning.md updated with experimental features.

Note

Low Risk
Log-only change that adds extra fields on successful block load; no functional, security, or data-path behavior changes.

Overview
Extends the store-gateway addBlock() success log line to include basic block metadata when a block is loaded during sync.

The loaded new block log now emits compaction_level, num_series, out-of-order flag (ooo), and the block time range (from/to), improving observability without changing load behavior.

Written by Cursor Bugbot for commit d5ab7dc. This will update automatically on new commits. Configure here.

@alexweav alexweav requested a review from a team as a code owner February 9, 2026 18:07
@alexweav alexweav added component/store-gateway changelog-not-needed PRs that don't need a CHANGELOG.md entry labels Feb 9, 2026
Copy link
Contributor

@narqo narqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but I agree in spirit 🔥

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Co-authored-by: Nick Pillitteri <56quarters@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-not-needed PRs that don't need a CHANGELOG.md entry component/store-gateway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments