Add config flag to enable delayed name removal for fallback Prometheus engine#14349
Add config flag to enable delayed name removal for fallback Prometheus engine#14349
Conversation
|
💻 Deploy preview available (Add config flag to enable delayed name removal for fallback Prometheus engine): |
56quarters
left a comment
56quarters
left a comment
There was a problem hiding this comment.
LGTM with Just naming suggestions.
tacole02
left a comment
tacole02
left a comment
There was a problem hiding this comment.
Docs look good! Thank you!
Co-authored-by: Nick Pillitteri <56quarters@users.noreply.github.com>
| f.IntVar(&cfg.MaxSamples, "querier.max-samples", 50e6, sharedWithQueryFrontend("Maximum number of samples a single query can load into memory.")) | ||
| f.DurationVar(&cfg.DefaultEvaluationInterval, "querier.default-evaluation-interval", time.Minute, sharedWithQueryFrontend("The default evaluation interval or step size for subqueries.")) | ||
| f.DurationVar(&cfg.LookbackDelta, "querier.lookback-delta", 5*time.Minute, sharedWithQueryFrontend("Time since the last sample after which a time series is considered stale and ignored by expression evaluations.")) | ||
| f.BoolVar(&cfg.EnableDelayedNameRemovalFallbackEngine, "querier.enable-delayed-name-removal-fallback-engine", false, "Enable the experimental Prometheus feature for delayed name removal in the fallback Prometheus engine. Note that this only applies when the Mimir Query Engine is enabled along with fallback to the Prometheus engine.") |
There was a problem hiding this comment.
Doesn't this apply regardless of whether or not MQE is enabled? eg. if -querier.query-engine=prometheus, this flag still applies.
There was a problem hiding this comment.
Should we just do f.BoolVar(&cfg.EnableDelayedNameRemovalPrometheusEngine, "querier.enable-delayed-name-removal-prometheus-engine", false, "Enable the experimental Prometheus feature for delayed name removal in the Prometheus engine. Note that this only applies when the Prometheus engine is selected or used as fallback from the Mimir Query Engine.") then?
4 participants
What this PR does
See title
Which issue(s) this PR fixes or relates to
Follow up to #13926 where we removed the ability to configure delayed name removal for Prometheus engine within Mimir
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.Not sure if we need a changelog as this is more for internal use?
Note
Low Risk
Small, opt-in config change affecting only the fallback Prometheus query engine path; default remains unchanged, but enabling it could subtly alter query behavior.
Overview
Adds a new experimental querier config/CLI flag,
-querier.enable-delayed-name-removal-fallback-engine, to control Prometheus delayed name removal when the system falls back from MQE to the Prometheus engine.Wires the flag through
pkg/querier/engine/config.gosopromql.EngineOpts.EnableDelayedNameRemovalis driven by config (instead of always disabled), and documents the option in the generated config descriptor, help text, docs, and the changelog.Written by Cursor Bugbot for commit 1923374. This will update automatically on new commits. Configure here.