feat: support custom labels in volumeClaimTemplates#14373
Open
grothej wants to merge 1 commit intografana:mainfrom
Open
feat: support custom labels in volumeClaimTemplates#14373grothej wants to merge 1 commit intografana:mainfrom
grothej wants to merge 1 commit intografana:mainfrom
Conversation
Allow to define labels for volume claims used by alertmanager, compactor, store-gateway and ingester statfulsets in mimir-distributed helm chart.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Enhances the mimir-distributed helm chart to define labels for PVCs used by alertmanager, compactor, store-gateway and ingester statfulsets in mimir-distributed helm chart.
Which issue(s) this PR fixes or relates to
Fixes #14266
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.Note
Low Risk
Small Helm templating change that only adds optional PVC labels; risk is limited to potential YAML rendering/indentation mistakes affecting the StatefulSets that use persistent volumes.
Overview
Helm chart now supports adding custom
metadata.labelsto thevolumeClaimTemplatesPVCs foralertmanager,compactor,ingester, andstore-gatewayStatefulSets via new*.persistentVolume.labelsvalues.Updates
values.yamlto expose the new options (default{}) and records the enhancement inCHANGELOG.md.Written by Cursor Bugbot for commit 641fd14. This will update automatically on new commits. Configure here.