storage/ingest: Support multiple Kafka seed broker addresses#14405
Closed
storage/ingest: Support multiple Kafka seed broker addresses#14405
Conversation
Contributor
|
TruffleHog Scan Results No secrets detected in this PR. |
Contributor
|
💻 Deploy preview deleted (storage/ingest: Support multiple Kafka seed broker addresses). |
Contributor
|
There is already #14328 from a community member, who is working on that. Do you want to help them with reviews instead? |
Contributor
Author
|
Ops, I missed that, thanks. I'll close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Makes
-ingest-storage.kafka.addressa comma-separated list instead of a single value, allowing users to pass multiple Kafka seed brokers.Which issue(s) this PR fixes or relates to
Part of #14073
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.Note
Medium Risk
Changes the type and parsing of a core ingest-storage Kafka config field, which may impact startup/connection behavior and backwards compatibility for existing deployments relying on the previous single-string semantics.
Overview
Adds support for configuring multiple Kafka seed brokers for ingest storage by changing
KafkaConfig.Addressfrom a single string toflagext.StringSliceCSV, updating flag registration and validation accordingly.Updates Kafka client creation to pass all configured seed brokers, and adjusts tests, docs/help text/config descriptor, and the changelog to reflect the new comma-separated
-ingest-storage.kafka.addressbehavior.Written by Cursor Bugbot for commit f306d14. This will update automatically on new commits. Configure here.