Skip to content

Experimental chunk iterator factory#14412

Closed
tcp13equals2 wants to merge 13 commits intomainfrom
experimental-chunk-iterator-factory
Closed

Experimental chunk iterator factory#14412
tcp13equals2 wants to merge 13 commits intomainfrom
experimental-chunk-iterator-factory

Conversation

@tcp13equals2
Copy link
Contributor

@tcp13equals2 tcp13equals2 commented Feb 19, 2026

What this PR does

This is an experimental build which pulls in grafana/mimir-prometheus#1106 over bot/main/update-mimir-prometheus-8aa312f6fd75-202602160717.

The changes made to use the new IteratorFactory() are then;

pkg/ingester/ingester.go

  • chunkSeriesNode.series: changed from []storage.ChunkSeries to []storage.ChunkIterable
  • getChunkSeriesNode(): allocates []storage.ChunkIterable
  • sendStreamingQuerySeries(): stores series.IteratorFactory() instead of the full series, and updated the comment to explain the rationale
  • sendStreamingQueryChunks(): unchanged — storage.ChunkIterable has the same Iterator(chunks.Iterator) chunks.Iterator method, so iterator reuse works identically

pkg/ingester/mirror_querier_test.go

  • Added IteratorFactory() to mockChunkSeries to satisfy the updated storage.ChunkSeries interface (which now embeds ChunkIterableFactory in the new prometheus commit)

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]. If changelog entry is not needed, please add the changelog-not-needed label to the PR.
  • about-versioning.md updated with experimental features.

mimir-github-bot bot and others added 11 commits February 18, 2026 17:14
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@tcp13equals2 tcp13equals2 changed the base branch from main to bot/main/update-mimir-prometheus-8aa312f6fd75-202602160717 February 19, 2026 01:35
@tcp13equals2 tcp13equals2 added the changelog-not-needed PRs that don't need a CHANGELOG.md entry label Feb 19, 2026
Base automatically changed from bot/main/update-mimir-prometheus-8aa312f6fd75-202602160717 to main February 19, 2026 07:30
@tcp13equals2
Copy link
Contributor Author

Replaced by #14422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-not-needed PRs that don't need a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments