fix(deps): update module golang.org/x/net to v0.50.0 (main)#14414
Open
renovate-sh-app[bot] wants to merge 1 commit intomainfrom
Open
fix(deps): update module golang.org/x/net to v0.50.0 (main)#14414renovate-sh-app[bot] wants to merge 1 commit intomainfrom
renovate-sh-app[bot] wants to merge 1 commit intomainfrom
Conversation
| datasource | package | from | to | | ---------- | ---------------- | ------- | ------- | | go | golang.org/x/net | v0.49.0 | v0.50.0 | Signed-off-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| FrameGoAway: parseGoAwayFrame, | ||
| FrameWindowUpdate: parseWindowUpdateFrame, | ||
| FrameContinuation: parseContinuationFrame, | ||
| FramePriorityUpdate: parsePriorityUpdateFrame, |
There was a problem hiding this comment.
Nil parser panic for HTTP/2 frame types 0xa-0xf
High Severity
Adding FramePriorityUpdate at 0x10 (decimal 16) expands the frameParsers array to 17 elements, leaving indices 10–15 as nil. The typeFrameParser function returns frameParsers[t] for any t < len(frameParsers), so frame types 0x0a–0x0f now return nil instead of parseUnknownFrame. This nil parser is immediately invoked at the call site in ReadFrameForHeader, causing a panic. Frame types 0x0a (ALTSVC) and 0x0c (ORIGIN) are legitimate registered HTTP/2 frame types that real peers may send. This is a known upstream regression (Go issue #77652).
Additional Locations (1)
|
Bugbot Autofix prepared fixes for 1 of the 1 bugs found in the latest run.
Or push these changes by commenting: Preview (ae6bb77ee2)diff --git a/vendor/golang.org/x/net/http2/frame.go b/vendor/golang.org/x/net/http2/frame.go
--- a/vendor/golang.org/x/net/http2/frame.go
+++ b/vendor/golang.org/x/net/http2/frame.go
@@ -145,7 +145,9 @@
func typeFrameParser(t FrameType) frameParser {
if int(t) < len(frameParsers) {
- return frameParsers[t]
+ if f := frameParsers[t]; f != nil {
+ return f
+ }
}
return parseUnknownFrame
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v0.49.0→v0.50.0Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
Need help?
You can ask for more help in the following Slack channel: #proj-renovate-self-hosted. In that channel you can also find ADR and FAQ docs in the Resources section.