Skip to content

dashboards: add dashboards_default_latency_mode config option#14424

Open
juliusmh wants to merge 1 commit intomainfrom
jmh/native_classic_default_dashboards
Open

dashboards: add dashboards_default_latency_mode config option#14424
juliusmh wants to merge 1 commit intomainfrom
jmh/native_classic_default_dashboards

Conversation

@juliusmh
Copy link
Contributor

@juliusmh juliusmh commented Feb 19, 2026

What this PR does

Dashboards have a toggle to select between native and classic latency histograms. Currently, this variable defaults to 'classic'.
When using native histograms (e.g. when converting classic -> native) this causes dashboards to show no data.

This PR adds support for overriding the default latency mode in dashboards to 'native'.

Checklist

  • [n/a] Tests updated.
  • [n/a] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]. If changelog entry is not needed, please add the changelog-not-needed label to the PR.
  • [n/a] about-versioning.md updated with experimental features.

Note

Low Risk
Config-only dashboard generation changes (variable defaults + dependency bump) with no runtime server logic; main risk is unexpected Grafana/dashboard rendering differences if the new default is mis-set.

Overview
Adds a new mixin config option, dashboards_default_latency_mode, to control the default selection for the dashboards’ native-vs-classic latency variable.

Updates all dashboards that expose the latency toggle to pass this configured default via a new dashboard-utils.libsonnet helper (latencyVariableDefault()), and bumps the grafana-builder jsonnet dependency lock to pick up required support.

Written by Cursor Bugbot for commit 8a45494. This will update automatically on new commits. Configure here.

@juliusmh juliusmh self-assigned this Feb 19, 2026
@juliusmh juliusmh force-pushed the jmh/native_classic_default_dashboards branch from 10982f4 to c78a10e Compare February 19, 2026 11:31
@juliusmh juliusmh marked this pull request as ready for review February 19, 2026 11:33
@juliusmh juliusmh requested a review from a team as a code owner February 19, 2026 11:33
…rol the default value of the native/classic latency variable
@juliusmh juliusmh force-pushed the jmh/native_classic_default_dashboards branch from c78a10e to 8a45494 Compare February 19, 2026 12:18
Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliusmh juliusmh requested a review from tacole02 February 19, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments