Skip to content

Update to orval version 8.5.x#112

Open
DefCon-007 wants to merge 3 commits intomainfrom
use-latest-orval-version
Open

Update to orval version 8.5.x#112
DefCon-007 wants to merge 3 commits intomainfrom
use-latest-orval-version

Conversation

@DefCon-007
Copy link
Copy Markdown
Collaborator

@DefCon-007 DefCon-007 commented Mar 3, 2026

Update to the orval version 8.5.1 which had some breaking changes.

Changes in the examples directory can be ignored as they are just formatting changes.

@DefCon-007 DefCon-007 force-pushed the use-latest-orval-version branch from 764a1d0 to 241ec43 Compare March 9, 2026 12:28
Comment thread tests/e2e/schema.json
"200": {
"description": "Item retrieved successfully"
}
},
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was failing the validation because of following, hence updated

  1. "Property headers is not expected to be here" at /paths/~1items-header/get

In OpenAPI 3.x, operation-level headers are not expressed as a top-level headers array.
They must be under parameters with "in": "header".
Main’s schema has a custom headers array next to parameters, which the validator rejects.

  1. "oneOf must match exactly one schema in oneOf" at /paths/~1items-header/get/requestBody

Main’s schema has "requestBody": { "required": false }.
A valid requestBody must describe content (e.g. with content) or match the expected schema shape; this fragment is invalid and triggers the oneOf validation error.

@DefCon-007 DefCon-007 changed the title Update to orval version 8.5.1 Update to orval version 8.5.x Mar 10, 2026
@DefCon-007 DefCon-007 marked this pull request as ready for review March 10, 2026 12:15
@DefCon-007 DefCon-007 requested a review from a team as a code owner March 10, 2026 12:15
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 65607e3414

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Array.isArray(schema.examples) &&
schema.examples.length > 0
) {
return `'${schema.examples[0]}'`
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep schema examples values in their original type

getExampleValueForSchema now returns '${schema.examples[0]}' whenever a schema has an examples array, which forces every example into a string literal. For OpenAPI 3.1 specs with numeric/boolean/object examples, the generated sample script now uses incorrect types (and object examples become '[object Object]'), so request bodies and params no longer match the schema. This is a regression introduced by the new examples branch.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant