-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add a package manager detection workflow #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we would be better of having this action as a "invoke pakage action" instead of having it returning the commands and then using the output to run those commands.
Can you expand on this idea a bit please I'm not following what "invoke package action" means? 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding an approval if you want to try this out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🚀
This PR adds a new workflow to the repo that detects the node package manager for the currently checked out repo.
We have pm.sh duplicated throughout this repo and in other ci-workflows we're sniffing the existence of lock files directly in the steps to understand what plugins are using. This PR introduces a workflow that runs
npx -y pm-detect
on a directory and returns it's output for future workflows to use.pm-detect returns a normalised map of the name of the package manager along with commands we want to run in CI.
NPM
Yarn
Yarn berry
PNPM