fix: allow OTLP allocation and lock thresholds - #351
Merged
korniltsev-grafanista merged 1 commit intoAug 18, 2026
Conversation
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
Contributor
Author
|
@korniltsev-grafanista to review |
| The agent sends protobuf requests to `<server-address>/v1development/profiles`. | ||
|
|
||
| OTLP export requires the default `ASYNC` profiler and is not supported by the JFR profiler used on Windows. | ||
| Only one profiling event can run at a time. Allocation and lock thresholds can be configured when their event is |
Contributor
There was a problem hiding this comment.
do not update readme. The information here is quickly outdated. The documentation lives in grafana/pyroscope repo.
korniltsev-grafanista
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows OTLP export to use allocation and lock profiling thresholds when the threshold configures the selected primary event.
Valid configurations now include:
and:
Previously, any use of
PYROSCOPE_PROFILER_ALLOCorPYROSCOPE_PROFILER_LOCKwith OTLP was rejected, even though async-profiler treats these values as thresholds for the selected event.The validation still rejects distinct events running simultaneously. Multiple events remain supported in sampling mode, where they run sequentially.
Changes
allocis the primary event.lockis the primary event.Testing
Fixes #347