Skip to content

fix: set async-profiler timeout for OTLP recordings - #353

Merged
korniltsev-grafanista merged 1 commit into
grafana:mainfrom
arnabnandy7:fix/otlp-recording-timeout
Aug 18, 2026
Merged

fix: set async-profiler timeout for OTLP recordings#353
korniltsev-grafanista merged 1 commit into
grafana:mainfrom
arnabnandy7:fix/otlp-recording-timeout

Conversation

@arnabnandy7

Copy link
Copy Markdown
Contributor

Description

Adds an async-profiler recording timeout for OTLP mode.

Previously, timeout was only included for JFR recordings. If scheduler ticks stalled while using OTLP, the in-memory recording could grow without a bound.

The OTLP start command now uses the existing upload-interval-derived timeout while continuing to omit the JFR-only file option.

Testing

./gradlew.bat :agent:test \
  --tests io.pyroscope.javaagent.AsyncProfilerDelegateCommandTest \
  --tests io.pyroscope.javaagent.AsyncProfilerDelegateTest

Result: BUILD SUCCESSFUL

Fixes #345.

Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
@arnabnandy7
arnabnandy7 requested review from a team as code owners August 16, 2026 12:45
@cursor

cursor Bot commented Aug 16, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@arnabnandy7

arnabnandy7 commented Aug 16, 2026

Copy link
Copy Markdown
Contributor Author

@korniltsev-grafanista @korniltsev to review

@korniltsev-grafanista

Copy link
Copy Markdown
Contributor

nit: JFR command has no test, only otlp. worth adding.

@korniltsev-grafanista
korniltsev-grafanista merged commit 54e4787 into grafana:main Aug 18, 2026
45 of 91 checks passed
@arnabnandy7

Copy link
Copy Markdown
Contributor Author

nit: JFR command has no test, only otlp. worth adding.

I'll add an issue and create separate PR for this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No async-profiler recording timeout in OTLP mode

2 participants