Added values file for demo #3813
Conversation
|
Thank you for the contribution @xogoodnow! Could you please run |
|
| Autogenerated from chart metadata using [helm-docs v1.8.1](https://github.com/norwoodj/helm-docs/releases/v1.8.1) | ||
| Autogenerated from chart metadata using [helm-docs v1.14.2](https://github.com/norwoodj/helm-docs/releases/v1.14.2) |
There was a problem hiding this comment.
One last bit to make the linter happy – we should either update the helm-docs version in the makefile or specify it manually here (1.8.1) or just run make helm/docs
|
Hi @kolesnikovae , |
|
Hi @xogoodnow, sorry for the late response, this seems to have fallen through the cracks. If you can update the PR one more time I'll make sure to merge it in. |
|
Hi @aleks-p, |
| @@ -403,13 +403,13 @@ helm/check: $(BIN)/kubeconform $(BIN)/helm | |||
| $(BIN)/helm template -n default --kube-version "1.23.0" pyroscope-dev ./operations/pyroscope/helm/pyroscope/ \ | |||
| | tee ./operations/pyroscope/helm/pyroscope/rendered/single-binary.yaml \ | |||
| | $(BIN)/kubeconform --summary --strict --kubernetes-version 1.23.0 | |||
| $(BIN)/helm template -n default --kube-version "1.23.0" pyroscope-dev ./operations/pyroscope/helm/pyroscope/ --values operations/pyroscope/helm/pyroscope/values-micro-services.yaml \ | |||
| $(BIN)/helm template -n default --kube-version "1.23.0" pyroscope-dev ./operations/pyroscope/helm/pyroscope/ --values operations/pyroscope/helm/pyroscope/values-micro-services-small.yaml\ | |||
There was a problem hiding this comment.
Looks like we replaced the rendered values-micro-services.yaml file, instead of creating a new one for -small. Could you restore the original line here and add a new helm template call for the -small file?
| | tee ./operations/pyroscope/helm/pyroscope/rendered/micro-services.yaml \ | ||
| | $(BIN)/kubeconform --summary --strict --kubernetes-version 1.23.0 | ||
| $(BIN)/helm template -n default --kube-version "1.23.0" pyroscope-dev ./operations/pyroscope/helm/pyroscope/ --values operations/pyroscope/helm/pyroscope/values-micro-services-hpa.yaml \ | ||
| | tee ./operations/pyroscope/helm/pyroscope/rendered/micro-services-hpa.yaml \ | ||
| | $(BIN)/kubeconform --summary --strict --kubernetes-version 1.23.0 | ||
| cat operations/pyroscope/helm/pyroscope/values-micro-services.yaml \ | ||
| cat operations/pyroscope/helm/pyroscope/values-micro-services-small.yaml\ |
There was a problem hiding this comment.
This causes the values of -small to be rendered in the default json (values-micro-services.json). Lets revert this line and add a brand new call that creates a new values-micro-services-small.json from the -small yaml.
| @@ -429,7 +429,7 @@ deploy: $(BIN)/kind $(BIN)/helm docker-image/pyroscope/build | |||
| deploy-micro-services: $(BIN)/kind $(BIN)/helm docker-image/pyroscope/build | |||
| # Ensure to delete existing service, that has been created manually by the deploy target | |||
| kubectl delete svc --field-selector metadata.name=pyroscope-micro-services-query-frontend -l app.kubernetes.io/managed-by!=Helm || true | |||
| $(call deploy,pyroscope-micro-services,--values=operations/pyroscope/helm/pyroscope/values-micro-services.yaml --set pyroscope.components.querier.resources=null --set pyroscope.components.distributor.resources=null --set pyroscope.components.ingester.resources=null --set pyroscope.components.store-gateway.resources=null --set pyroscope.components.compactor.resources=null) | |||
| $(call deploy,pyroscope-micro-services,--values=operations/pyroscope/helm/pyroscope/values-micro-services-small.yaml--set pyroscope.components.querier.resources=null --set pyroscope.components.distributor.resources=null --set pyroscope.components.ingester.resources=null --set pyroscope.components.store-gateway.resources=null --set pyroscope.components.compactor.resources=null) | |||
There was a problem hiding this comment.
looks like we are missing a space here before the first --set
Hi,
Based on this PR, decided to set a separate values file for lab/demo environments with much less required resources.
Cheers