feat(v2): time-based compaction #4098
Merged
+371
−174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
force-pushed
the
feat/compact-aged-blocks
branch
2 times, most recently
from
684f8ac to
353da42
Compare
kolesnikovae
force-pushed
the
feat/compact-aged-blocks
branch
from
353da42 to
76cfaa9
Compare
korniltsev
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds time-based compaction. Currently, blocks remain uncompacted until there are enough of them within the tenant-shard-level dimension. This can be problematic, for example, if shards are removed – those blocks will remain in the queue indefinitely (until the shards are added back). Another case where this issue may arise is when ingestion is very slow (e.g., one profile per minute) or intermittent: blocks may contain data that is too far apart, and we don’t want to merge such blocks.