profilecli(canary): do not check for service.name label #4677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korniltsev-grafanista
requested review from
a team,
aleks-p and
marcsanmi
as code owners
simonswine
pushed a commit
that referenced
this pull request
Dec 9, 2025
simonswine
added a commit
that referenced
this pull request
Dec 9, 2025
* profilecli(canary): do not check for service.name label (#4677) * fix: No data for format=dot queries, should not result in a 500 (#4675) --------- Co-authored-by: korniltsev-grafanista <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #4662 we used to (some times?) store unsanitized labels. Now we don't.
Until we properly store utf8 labels, we should not check for incorrect label
service.namein the canary exporter