chore: update rideshare examples #4683
Merged
+176
−127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you verify |
Contributor
|
Here is the test run: https://github.com/grafana/pyroscope/actions/runs/20128634602/job/57764240900 The python errors are because of a broken release pipeline to python, I am trying to fix this: |
Contributor
Author
I only updated the examples that we use to produce images and from what I can see those passed in the run @simonswine mentioned (I downgraded the broken dependency to a working one in the flask example). I will do a follow up at a future time to update the rest of the examples as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the rideshare example apps that we use to produce internal images we use for demo purposes. The changes aim to address security vulnerabilities, once merged we can run
make rideshare/docker/pushto produce the actual images.This is a stop-gap solution, in the future we could consider expanding
make tools/update_examplesto do similar upgrades (in addition to what it currently does).