fix: Assign appropriate HTTP status codes to errors #4684
Merged
+6
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were incorrectly getting SLO read budget burns because some of our validation was being incorrectly returned as 5xx when they should have been 4xx. The read budget burns were specifically impacting our
/renderendpoint. I went through and cleaned up as many of the errors as I could, assigning them appropriate status codes.This also removes some usages of
github.com/gogo/statusin favor of connect error codes (ultimately everything will be resolved to an HTTP status code).