Skip to content

Conversation

@bryanhuhta
Copy link
Contributor

We were incorrectly getting SLO read budget burns because some of our validation was being incorrectly returned as 5xx when they should have been 4xx. The read budget burns were specifically impacting our /render endpoint. I went through and cleaned up as many of the errors as I could, assigning them appropriate status codes.

This also removes some usages of github.com/gogo/status in favor of connect error codes (ultimately everything will be resolved to an HTTP status code).

@bryanhuhta bryanhuhta self-assigned this Dec 11, 2025
@bryanhuhta bryanhuhta requested a review from a team December 11, 2025 00:37
Copy link
Contributor

@korniltsev-grafanista korniltsev-grafanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to have a test, so that we don't accidentally turn them into 5xx again later

@bryanhuhta
Copy link
Contributor Author

I have #4685 open to add more thorough tests for all public read path endpoints. I'm going to merge this PR as-is so the changes here don't get lost in the much larger set of changes in #4685.

@bryanhuhta bryanhuhta merged commit ced5b01 into main Dec 11, 2025
21 checks passed
@bryanhuhta bryanhuhta deleted the huhta/fix-error-types branch December 11, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants