-
Notifications
You must be signed in to change notification settings - Fork 50
Filtering: NonApplicability improvements #1373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mdvictor
wants to merge
27
commits into
main
Choose a base branch
from
mdv/non-applicable-filters-prometheus
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
ab898b3
per panel non applicability
mdvictor 7413638
fix
mdvictor 33b4091
refactor
mdvictor bea96d7
refactor
mdvictor e6e7296
Merge branch 'main' into mdv/non-applicable-filters-prometheus
mdvictor 3f5d04a
refactor
mdvictor 25b514e
fix + tests
mdvictor 5c146bc
add extra gate
mdvictor b24b42f
fix
mdvictor 90de9f9
fix tests
mdvictor d510a18
enforce feature toggle
mdvictor 22231aa
test fixes + cache
mdvictor 76582e9
use stringify for caching
mdvictor 1ea1e59
merge
mdvictor 5d7ed6e
fix
mdvictor 0b5806a
fix
mdvictor cfbfa10
fix test
mdvictor 78beba4
fix
mdvictor d7f4cb5
fix tests, order of filters must be maintained
mdvictor dc5fd3c
fix
mdvictor cdae7e7
fix
mdvictor 6723f29
fixes
mdvictor e32af32
remove query caching -- keep it only for filters/groupBys/scopes
mdvictor 65b52e4
refactor applicability, remove some groupBy logic
mdvictor 200f5fc
fixes
mdvictor 5769a1f
fixes
mdvictor 7543750
fix
mdvictor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to await here? This is gonna block query execution. Maybe instead just fire this funtion without await.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could let it fire and not block querying but then we would cancel inflights and requuery as soon as applicability resolves so we get the correct filters for the given queries