AdHocFiltersRecommendations: Dedupe filters#1379
Merged
Conversation
Comment on lines
+199
to
+201
| (f: AdHocFilterWithLabels) => | ||
| !(f.key === filter.key && f.operator === filter.operator && f.value === filter.value) | ||
| ); |
Contributor
There was a problem hiding this comment.
not a blocker so your call but this could be a bit improved by reusing deduplicateFilters({ ...allRecentFilters, filter })so we dont duplicate the comparison. It will take us from O(n) to O(n2) but switching from an Array to a Map would fix it as well
Collaborator
Author
There was a problem hiding this comment.
great catch! we have a hard limit on these keys of 10 so performance wouldn't be a big issue, but nonetheless you are right and optimizations are always good! I've moved the O(n^2) deduplication to a linear map. Thank you!
kristinademeshchik
approved these changes
Mar 13, 2026
mdvictor
added
patch
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug where adding mulitple times the same filter would then show that same filter duplicated in the recent filters area. This PR adds deduping so it only shows unique recent filters
For testing:
drilldownRecommendations