Jest: Upgrade jest to fix issue with logging scene objects#1426
Open
Jest: Upgrade jest to fix issue with logging scene objects#1426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like jest did not always call toJSON on object prototypes (only instances) so we still have issues with jest crashing when logging scene object instances. Related to #1070
fixes issues like.
The latest jest fixes this issue. I was unable to create a test case for this as it only happens if an outer expect fails (not possible to replicate with an expect throws, for example).
We need to upgrade jest in core repo as well to fix it there