Skip to content

feat(push-to-gcs): add process_gcloudignore input #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tolzhabayev wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(push-to-gcs): add process_gcloudignore input #1593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d43190b
adding process_gcloudignore as input with default false
tolzhabayev Dec 5, 2025
cb11d1f
update readme
tolzhabayev Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions actions/push-to-gcs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ jobs:
| `predefinedAcl` | String | Predefined ACL applied to the uploaded objects. Default is `projectPrivate`. See [Google Documentation][gcs-docs-upload-options] for a list of available options. |
| `delete_credentials_file` | Boolean | Delete the credentials file after the action is finished. If you want to keep the credentials file for a later step, set this to false. (Default: `true`) |
| `use_wif_auth` | Boolean | Use WIF authentication. Overrides the `service_account` input. |
| `process_gcloudignore` | Boolean | Whether to process `.gcloudignore` file. (Default: `false`) |

> [!TIP]
> To use WIF authentication you must enable `uniform_bucket_level_access` on the destination bucket. If you are at Grafana Labs, instructions can be found [here](https://enghub.grafana-ops.net/docs/default/component/deployment-tools/platform/continuous-integration/google-artifact-registry/). More info can be found in [Google's docs](https://cloud.google.com/storage/docs/uniform-bucket-level-access).
Expand Down
7 changes: 6 additions & 1 deletion actions/push-to-gcs/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ inputs:
Use WIF for authentication instead of service account.
required: false
default: "false"
process_gcloudignore:
description: |
Whether to process .gcloudignore file.
required: false
default: "false"

outputs:
uploaded:
Expand Down Expand Up @@ -114,7 +119,7 @@ runs:
parent: ${{ inputs.parent }}
predefinedAcl: ${{ inputs.use_wif_auth == 'true' && ' ' || inputs.predefinedAcl }} # when using WIF auth, we cannot use predefinedAcl
gzip: ${{ inputs.gzip }}
process_gcloudignore: false
process_gcloudignore: ${{ inputs.process_gcloudignore }}
Copy link
Contributor

@ricky-undeadcoders ricky-undeadcoders Dec 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
process_gcloudignore: ${{ inputs.process_gcloudignore }}
process_gcloudignore: ${{ inputs.process_gcloudignore == 'true' }}

This should probably be passed as a boolean type since that's what upload-cloud-storage expects.

Otherwise LGTM, thanks for adding this in!


- name: Cleanup checkout directory
if: ${{ !cancelled() }}
Expand Down
Loading